mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 23:15:49 +03:00
[GH-ISSUE #1069] State reason for failure (late or explicit failure) in notifications #742
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#742
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rwjack on GitHub (Oct 10, 2024).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/1069
Related: https://github.com/healthchecks/healthchecks/discussions/1067
@cuu508 commented on GitHub (Nov 8, 2024):
I updated the Flip object to track failure reason, and updated the email template. When the grace time runs out:
When the check receives a failure signal:
@rwjack, @davidkcarey thoughts on this, does this help?
Changing the contents of the subject line is risky, as people may already have email filters set up that look for the "DOWN" keyword.
I thought about adding a more verbose paragraph explaining why a check went down. Something like:
And even fancier way would be to show a visual timeline of (non-)events:
Problems with this:
@rwjack commented on GitHub (Dec 1, 2024):
Excuse the late reply, been busy lately.
Yeah, I think your implementation would solve the original issue, in the email notification description at least. That's where verbose paragraph would come into play, but for existing simple notifications (I use matrix):
[STATE] - check name, something like[STATE] [MISSED GRACE] - check namewould make more sense.Although it might be a better idea to just update the matrix template to include data from your 2nd screenshot. Then the verbose paragraph solution would solve it everywhere.
Also, seeing your 3rd image of the timeline, upped the initial idea, and it really would look great. Not necessarily in notifications, but on the webapp itself.
@cuu508 commented on GitHub (Dec 13, 2024):
@rwjack, by the verbose paragraph do you mean these?
and
I started with the email integration as it is the most used one, but once we settle on a pattern I'm going to gradually update all other integrations to use the same or a similar pattern.
The issue I see with
[STATE] [MISSED GRACE] - check nameis for some users it would be unclear what "MISSED GRACE" means. You know it, and from the context in this issue I know it, but for a new user it could be confusing.@cuu508 commented on GitHub (Dec 13, 2024):
Matrix messages support fair few HTML tags and attributes. I updated the message template to be similar to Signal, Telegram templates, and to include tags, schedule, last ping body, a list of other checks that are down.
Here's how it looks now:
I couldn't get two-column layout as in Slack and email messages. There are table tags, but Element renders the tables with borders and alternating row background colors, so not useful for layout:
@rwjack commented on GitHub (Dec 15, 2024):
The matrix template is perfect now, that should be all!
I get what you're saying.
By verbose paragraph, I mean the whole new updated email template: