mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 15:05:49 +03:00
[GH-ISSUE #994] Get informed if job run time is too short #694
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#694
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Yaya-Cout on GitHub (Apr 15, 2024).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/994
Recently, I realized that my MariaDB was not dumping to the backup due to a configuration error. (I renamed the config file without using the new name in the script). Healthcheck.io should have notified me, but, as my command is something like
mysqldump | gpg, mysql error was not detected by my script (I fixed it now withset -o pipefail).This case could be detected by Healthcheck.io by checking if the job is running too fast (because dumping is way faster without dumping 😄) and notifying in this case.
If we want to go further, we could set this time semi-automatically by comparing to the previous run and checking if there is too much variation (maybe in both side, too long and too fast, but it might be redundant with grace time), like +/- 20% of the previous run time (configurable). I don't know if it's a good idea because it would be "probabilistic" and can fail to detect failures. Another problem is to know if Healthcheck.io should send a down message (even if the next run would probably run successfully as the base time have changed) or just a warning.
Anyway, thanks for this great software, it is so useful, have many features and simple to use.
@cuu508 commented on GitHub (Apr 16, 2024):
Thanks for the suggestion, and for the explanation of the use case. There's a similar feature request – #236 – so I will close this one.
@cuu508 commented on GitHub (Apr 16, 2024):
I added a note about using
set -o pipefailin docs:github.com/healthchecks/healthchecks@0b28aa1cdf