mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-26 07:25:51 +03:00
[GH-ISSUE #980] RP_ID can't be changed after initial deployment? #686
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#686
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @pro-sumer on GitHub (Mar 26, 2024).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/980
Until today I was using this configuration and 2FA via security keys worked fine:
When I tried to move to a different subdomain (but keeping the old one for pings) adding 2FA via security keys no longer works (I removed all keys before the move):
Without 2FA I can log in on both
another_sub.domain.tldandsub.domain.tld. However, when I try to add security keys onanother_sub.domain.tldI get the error message "SecurityError: The provided RP ID is not a registrable domain suffix of the effective domain of the document.". Additionally, security keys can still be added onsub.domain.tld.I did restart the Docker container. Why is it still using the old RP_ID value?
PS: I can't currently test any further due to this additional error: "Too Many Requests. Please try again later."
@cuu508 commented on GitHub (Mar 27, 2024):
When you are on the "Add Security Key" page and are about to enter the new key's name, please view the page source and look for a line that looks like so:
In the JSON string,
publicKey.rp.idkey, does it show "another_sub.domain.tld"?And, just to make sure, is the page URL
https://another_sub.domain.tld/accounts/two_factor/webauthn/?@pro-sumer commented on GitHub (Mar 27, 2024):
Today adding the keys worked just fine... (and all the values seem to be as expected).
Could it be a browser cache issue yesterday?
Anyway, feel free to close this issue.