mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 15:05:49 +03:00
[GH-ISSUE #774] Feature Request: ping response body compatible with Prometheus format #542
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#542
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fabricat on GitHub (Jan 13, 2023).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/774
I'd like to use your service in order to ensure that my Prometheus server is up. Unfortunately, since the ping response body is just
OK, Prometheus does not recognize the format and marks the target as DOWN.Despite the main goal (checking whether Prometheus is working) is achieved correctly, a small change (just add a fake value after "OK") could also avoid errors on Prometheus' side.
Can you make it possible to select an "output format", e.g. by accepting a
formatquery parameter to the ping URL?The code should be changed from this:
github.com/healthchecks/healthchecks@f849c5e1a1/hc/api/views.py (L84)into something like this (sorry for the ugly code 😓 I am not a Python developer):
That would be an enticing new feature, that only the best-in-class provide 😉
@cuu508 commented on GitHub (Jan 16, 2023):
Hi @fabricat, thanks for the suggestion!
I've considered this feature before, but ultimately decided against it – it would be a useful, but a niche feature. And I think it would be too niche to warrant the extra complexity. If I see ongoing demand for it, I will reconsider.