mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 15:05:49 +03:00
[GH-ISSUE #745] Table overlapping div container #531
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#531
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @solracsf on GitHub (Dec 3, 2022).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/745
See screenshot. As you can observe,
tableis bigger than parentdiv, resulting inoverflow-y. v2.4.1This can be observed when switching Ping URL to Slug and having pretty big URls (but not that big...) like:
https://health.examplers.com/ping/gBnsq5Q5c-PlRRh5ucCFRQ/205464390-badd3e02-0007-4b64-bb1f@cuu508 commented on GitHub (Dec 14, 2022):
Thanks for the report.
This is a tricky one. One potential fix I'm considering is:
table-layout: fixedtext-overflow: ellipsison the URL column@solracsf commented on GitHub (Dec 14, 2022):
Is it necessary to display the
https://health.examplers.com/ping/part?Displaying only the
uuidorslugbut keep the copy action with full URI could be an option too.Something like
@ping/gBnsq5Q5c-PlRRh5ucCFRQ/zeojfio-zkej-akzjda-zkjef-skjhfebzeEDIT: after rethinking not a good option because it always depends on the length on the slug part; should it have a lot of chars, problem will remain...
@cuu508 commented on GitHub (Dec 14, 2022):
It's nice to show the full URL, if space allows:
The difficulty is that slugs can be up to 100 characters long. And the
https://health.examplers...part can be arbitrarily long. And there are different screen sizes and zoom levels. It's hard to know in advance what will fit and what will not.I guess one way out is to allow the URL to wrap. It starts to look cluttered, but at least it's functional, the full URL is there:
@solracsf commented on GitHub (Dec 14, 2022):
Well, the URL is already wrapping on the details page so not a deal breaker IMO. 👍
