mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-26 07:25:51 +03:00
[GH-ISSUE #732] signal-cli binary in docker image #525
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#525
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SecT0uch on GitHub (Nov 13, 2022).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/732
It seems the signal-cli binary in not included in the docker image.
It is needed for the Signal integration
Would it be possible to make it available ?
Edit: Submitted #733
@cuu508 commented on GitHub (Nov 13, 2022):
Wouldn't it be better to signal-cli in a separate container?
@SecT0uch commented on GitHub (Nov 13, 2022):
That's what I initially did, sharing the signal socket between the containers.
However signal-cli needs to be available in healthchecks container to connect to the socket.
Am I missing something ?
@cuu508 commented on GitHub (Nov 13, 2022):
Did sharing the socket between the containers not work? What problem did you hit?
(note – I've not personally tested running healthchecks and signal-cli in separate containers, but I assumed there must be a way to make a socket from one container available to another container)
@SecT0uch commented on GitHub (Nov 13, 2022):
I did manage to share the socket between the containers.
The issue is when testing my Signal integration:
Could not send a test notification. signal-cli call failed@cuu508 commented on GitHub (Dec 15, 2022):
I got it semi-working with the following docker-compose file:
And I had this in
.envfile:But using volumes to share sockets is quite clumsy. I had permission problems with socket files – I had to chmod the socket file so the healthchecks process would be able to access it. And, after stopping and restarting containers, the signal-cli container complained about the socket file already being there – I had to manually remove it between restarts.
I'm inexperienced with docker, there may be proper ways to solve the above issues.
As an experimental alternative I added support for connecting to a TCP socket in
73a5cb0d57. TCP communication between containers is simpler–no volumes, no sokcet files:And I had this in
.envfile: