mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 23:15:49 +03:00
[GH-ISSUE #675] SITE_NAME ignored on Integrations (at least VictorOps / Splunk OnCall) #486
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#486
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @s256 on GitHub (Jul 18, 2022).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/675
We are trying to get our custom
SITE_NAMEasmonitoring_toolin VictorOps / Splunk On-Call, but unfortunately alwaysMychecksappears asmonitoring_tool.I am running
healthchecksas a systemd with this config:and alerts with
While the Web UI reflects the
SITE_NAME- VictorOps does not.I tried replacing the
settings.SITE_NAMEin https://github.com/healthchecks/healthchecks/blob/master/hc/settings.py#L158= with some hardcoded value, but nothing changes.Also tried to replace it in the
transports.pyhttps://github.com/healthchecks/healthchecks/blob/master/hc/api/transports.py#L547 without success.I also tried running it without
uwsgiin debug mode withmanage.py runserverbut still the same behaviour.Additionally I removed all
*.pycfiles in the directory to make sure that's not a caching problem.Expected Behaviour:
Replace all appearances of
SITE_NAMEwith value from Environment variable.Actual Behaviour:
SITE_NAMEis only set in webUI but not in integrations.@cuu508 commented on GitHub (Jul 19, 2022):
You don't have
Environment=SITE_NAME="My Cron Monitoring"in the sendalerts systemd unit, so it uses the default value, "Mychecks".@s256 commented on GitHub (Jul 19, 2022):
Thank you, that fixed it... But why didn't my changes in https://github.com/healthchecks/healthchecks/blob/master/hc/api/transports.py#L547 lead to the same result?
Should have led to the same result, right?
@cuu508 commented on GitHub (Jul 19, 2022):
Yes, it should have the same result. Two guesses:
sendalertsservice?@s256 commented on GitHub (Jul 19, 2022):
probably number 2) not restarting the
sendalertsbut theuwsgiservice...Thank you! I'll close the issue. :)