mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 23:15:49 +03:00
[GH-ISSUE #550] Add placeholder file for /static/img/logo-full@2x.png #399
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#399
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SuperSandro2000 on GitHub (Aug 11, 2021).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/550
I noticed while setting up 2FA that
/static/img/logo-full@2x.pnghas no placeholder file. Could you add one?@cuu508 commented on GitHub (Aug 12, 2021):
It used to exist, I removed it when adding
SITE_LOGO_URLsetting –github.com/healthchecks/healthchecks@2382bf6722, #323Changes:
SITE_LOGO_URLsetting and alsoSITE_LOGO_FULL_URLsetting.SITE_LOGO_URLto a SVG file.@SuperSandro2000 commented on GitHub (Aug 12, 2021):
So you are suggesting that I should set SITE_LOGO_URL to the left over logo file?
Could this be the default if nothing is set?
I don't have any logo and I don't want to add one because I am just using the site for myself but it didn't look that nice when the mail referenced a not existing file.
@cuu508 commented on GitHub (Aug 13, 2021):
Ah, OK, I understand the problem now. I had updated the base template for HTML pages, but forgot to update the email template, it was still referencing
logo-full@2x.png.Fixed now: email template will use
SITE_LOGO_URLif set, and fall back to/static/img/logo.png.