[GH-ISSUE #550] Add placeholder file for /static/img/logo-full@2x.png #399

Closed
opened 2026-02-25 23:42:19 +03:00 by kerem · 3 comments
Owner

Originally created by @SuperSandro2000 on GitHub (Aug 11, 2021).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/550

I noticed while setting up 2FA that /static/img/logo-full@2x.png has no placeholder file. Could you add one?

Originally created by @SuperSandro2000 on GitHub (Aug 11, 2021). Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/550 I noticed while setting up 2FA that ``/static/img/logo-full@2x.png`` has no placeholder file. Could you add one?
kerem closed this issue 2026-02-25 23:42:19 +03:00
Author
Owner

@cuu508 commented on GitHub (Aug 12, 2021):

It used to exist, I removed it when adding SITE_LOGO_URL setting – github.com/healthchecks/healthchecks@2382bf6722, #323

Changes:

  • There are no "logo" and "logo-full" variations any more. There's just one version of logo. Otherwise we would need SITE_LOGO_URL setting and also SITE_LOGO_FULL_URL setting.
  • There are no regular and @2x variations. To get crisp rendering on high DPI screens, either use a larger png, or point SITE_LOGO_URL to a SVG file.
<!-- gh-comment-id:897446974 --> @cuu508 commented on GitHub (Aug 12, 2021): It used to exist, I removed it when adding `SITE_LOGO_URL` setting – https://github.com/healthchecks/healthchecks/commit/2382bf6722dcb00d0d4ce1bc57b07cf9efaed154, #323 Changes: * There are no "logo" and "logo-full" variations any more. There's just one version of logo. Otherwise we would need `SITE_LOGO_URL` setting and also `SITE_LOGO_FULL_URL` setting. * There are no regular and @2x variations. To get crisp rendering on high DPI screens, either use a larger png, or point `SITE_LOGO_URL` to a SVG file.
Author
Owner

@SuperSandro2000 commented on GitHub (Aug 12, 2021):

So you are suggesting that I should set SITE_LOGO_URL to the left over logo file?

Could this be the default if nothing is set?

I don't have any logo and I don't want to add one because I am just using the site for myself but it didn't look that nice when the mail referenced a not existing file.

<!-- gh-comment-id:897748497 --> @SuperSandro2000 commented on GitHub (Aug 12, 2021): So you are suggesting that I should set SITE_LOGO_URL to the left over logo file? Could this be the default if nothing is set? I don't have any logo and I don't want to add one because I am just using the site for myself but it didn't look that nice when the mail referenced a not existing file.
Author
Owner

@cuu508 commented on GitHub (Aug 13, 2021):

Ah, OK, I understand the problem now. I had updated the base template for HTML pages, but forgot to update the email template, it was still referencing logo-full@2x.png.

Fixed now: email template will use SITE_LOGO_URL if set, and fall back to /static/img/logo.png.

<!-- gh-comment-id:898388079 --> @cuu508 commented on GitHub (Aug 13, 2021): Ah, OK, I understand the problem now. I had updated the base template for HTML pages, but forgot to update the email template, it was still referencing `logo-full@2x.png`. Fixed now: email template will use `SITE_LOGO_URL` if set, and fall back to `/static/img/logo.png`.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/healthchecks#399
No description provided.