mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #512] SMS message when service back UP not delivered #375
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#375
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @danemacmillan on GitHub (May 12, 2021).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/512
This may be intentional, but I recently started testing the possibility of transitioning from Pushover to regular SMS, and I noticed that SMS only delivers DOWN notifications, but not notifications when a service comes back UP. Is this on purpose, or is this a bug?
I currently have both Pushover and SMS notifications configured, and that's how I noticed, because Pushover receives UP notifications.
@cuu508 commented on GitHub (May 21, 2021):
It was on purpose. My assumption was users would want to use SMS for more urgent messages since SMS has limited monthly quota, and SMS typically arrives in real time (not lazily, when you wake up a device, as emails sometimes would). And "DOWN" notifications would of course be more urgent than "UP".
Looking at it with today's eyes, I think it's better to give users a choice, like we do with email notifications:
@cuu508 commented on GitHub (May 21, 2021):
FYI – I added the "Notify When" option for new SMS integrations, and deployed the change to https://healthchecks.io.
@danemacmillan commented on GitHub (May 21, 2021):
Awesome, thanks! Always super responsive.