mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 23:15:49 +03:00
[GH-ISSUE #473] Cron expression with commas causes warning #352
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#352
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bradbeattie on GitHub (Feb 1, 2021).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/473
45 9,19 * * *is showing me an warning, even though the cronjob is running on time. Adjusting the expression to45 9 * * *out of curiosity then shows the check as healthy. So it looks like cron expressions with commas aren't being considered correctly.@bradbeattie commented on GitHub (Feb 1, 2021):
Running on v1.18.0, if that helps.
@cuu508 commented on GitHub (Feb 1, 2021):
By warning, do you mean the orange warning icon ("late" status)?
Can you post here or email me a screenshot of the check's details page when it is in the warning state (interested in seeing the schedule, timezone, and the log of received pings)?
@bradbeattie commented on GitHub (Feb 1, 2021):
Interesting. Now that I go to check it, I see more orange warning icons than expected (late status).
But in the screenshot attached, the last ping was 22 hours ago, within the expected 24h window.
My browser's time is UTC-8 and so its the server that runs the cronjob... oh wait. Does Healthchecks assume that a cron expression is expressed in UTC? Such that
0 10 * * *means 10am UTC+0? That might be the source of the hiccup here.@bradbeattie commented on GitHub (Feb 1, 2021):
Yeah, that was it. Apologies. I had set these before, but failed to set the server timezone when recreating the checks last time.
@andyg2 commented on GitHub (Jan 13, 2023):
I have a similar problem to this
A cron schedule for ever hour between 9am and 5pm
The last check was 26 minutes ago at 10am and a grace period of 1 hour (10:26 currently)
Perhaps I misunderstand how the grace period but from what it seems I should not be seeing a late status.
@cuu508 commented on GitHub (Jan 13, 2023):
@andyg2 it does not look right to me too. Is this on healthchecks.io or a self-hosted instance?
@andyg2 commented on GitHub (Jan 16, 2023):
It's self hosted. Oh, linuxserver docker image though, will report there instead. Will update here if I find anything useful as it seems related to this issue.