mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 15:05:49 +03:00
[GH-ISSUE #463] RocketChat Integration #347
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#347
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @scornet256 on GitHub (Dec 26, 2020).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/463
I'm using the Mattermost integration with my RocketChat instance, which works perfectly.
Just wanted to let you or others know.
@fbartels commented on GitHub (Dec 27, 2020):
I can confirm this
@cuu508 commented on GitHub (Dec 28, 2020):
Thanks for the hint!
The Mattermost integration currently uses the exact same notification JSON template as Slack. We still list it as a separate integration, so it can have its own specific setup instructions, and also so that we can split the notification templates in the future if need be.
It would be similar with RocketChat – ideally we'd still want a separate integration with its own setup instructions, even if the JSON template is initially the same.
Also something I must keep in mind: when tweaking the Slack template, I should test Mattermost & RocketChat too!
@Dr-Shadow commented on GitHub (May 22, 2023):
#785 is now adding a body in the message for the mattermost integration which is not correctly supported when this integration is used with RocketChat.
The Slack integration has the same problem if used directly in RocketChat.
So, it seems the JSON template starts to need some tweaking
Example :
@cuu508 commented on GitHub (May 30, 2023):
I tried a few things but so far I haven't figured out a syntax that would work with Rocket.Chat. Multi-line pre-formatted text works in normal messages, and in the
textfield in message attachments, but not insidefields.What I can do for now is add a Rocket.Chat integration which posts the same payload as Mattermost, but exclude the last ping body field. Instead of showing badly formatted Last Ping Body, the notifications would then show no Last Ping Body.
@cuu508 commented on GitHub (May 30, 2023):
One idea I had was to add a second attachment, and put last ping body in its
textfield:But this approach has problems too:
@Dr-Shadow commented on GitHub (May 30, 2023):
I'm getting this display because I didn't want to spend to much time around the attachment blocks.
I used an integration script to rewrite the json body received by rocket chat
EDIT : so i believe just putting the body in the text section 'should' be fine but that's only my point of view
@cuu508 commented on GitHub (May 30, 2023):
Yes, putting it in the text field (outside the attachments) works. We could also post it as a separate message, so it comes after the check details, not before:
@Dr-Shadow commented on GitHub (May 30, 2023):
I believe it would be better to use only 1 message for the entire alert. I'm fine with the body before the attachment
@cuu508 commented on GitHub (May 30, 2023):
Yep, keeping it in a single message would be better.
I'm not happy with putting the last ping body before the check details. The most important information in the alert is: what check changed state? What is its new state? What is its schedule and how long ago was the last ping? These bits should come first.
Another idea would be to show only a very short excerpt of the last ping body, plus a link to full details:
@Dr-Shadow commented on GitHub (Jun 1, 2023):
You're right but our people at our company do not use the healtchecks website so they don't have an account on it :/
It would be a good idea to include a body the "test" hook from the integrations (especially mattermost and slack right now) so I can dig a bit further in the diagnosis as well.
@cuu508 commented on GitHub (Jun 2, 2023):
One possible solution is to invite them into the project. When inviting team members you can also set the access level to read-only.
You can also set up email integrations for them, email notifications do contain the last ping body (well, first 10'000 bytes of it).
Yep, we could do that. Would you be testing how notifications look in different chat platforms, to decide which chat platform to use?
@Dr-Shadow commented on GitHub (Jun 2, 2023):
Yes, I am aware of it. I am already truncating my submitted log to the healthchecks api so that I only include the last 10'000 bytes
Yes I was already planning to do that once I come back from my holiday leave next week :)
@cuu508 commented on GitHub (Jun 3, 2023):
I updated the notification template to show the last ping body size in bytes, and a link to view the full body:
When or if Rocket.Chat improves the support for showing preformatted text, I'm happy to adjust the notification template.
@cuu508 commented on GitHub (Jun 5, 2023):
The initial version of the Rocket.Chat integration is ready for business, and is also deployed to the hosted service at https://healthchecks.io.