[GH-ISSUE #408] CI Build failure introduced by commit "Use separate counters for SMS and phone calls." #305

New issue

Closed

opened 2026-02-25 23:41:58 +03:00 by kerem · 1 comment

kerem commented

2026-02-25 23:41:58 +03:00

Owner

Originally created by @iphoting on GitHub (Aug 5, 2020).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/408

https://travis-ci.org/github/healthchecks/healthchecks/builds/714508466

FAIL: test_it_sends_link (hc.accounts.tests.test_signup.SignupTestCase)
282----------------------------------------------------------------------
283Traceback (most recent call last):
284  File "/home/travis/build/healthchecks/healthchecks/hc/accounts/tests/test_signup.py", line 23, in test_it_sends_link
285    self.assertEqual(profile.sms_limit, 5)
286AssertionError: 500 != 5

Looks like it might be introduced by the following bug in the test, when USE_PAYMENTS=False is the default:

        # A profile should have been created
        profile = Profile.objects.get()
        self.assertEqual(profile.sms_limit, 5)
        self.assertEqual(profile.call_limit, 0)

Ref: github.com/healthchecks/healthchecks@77ee8452c5...8c13457037 (diff-9336213c71d0ba69ae89055c09e2c53aR21-R25)

Originally created by @iphoting on GitHub (Aug 5, 2020). Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/408 https://travis-ci.org/github/healthchecks/healthchecks/builds/714508466 ``` FAIL: test_it_sends_link (hc.accounts.tests.test_signup.SignupTestCase) 282---------------------------------------------------------------------- 283Traceback (most recent call last): 284 File "/home/travis/build/healthchecks/healthchecks/hc/accounts/tests/test_signup.py", line 23, in test_it_sends_link 285 self.assertEqual(profile.sms_limit, 5) 286AssertionError: 500 != 5 ``` Looks like it might be introduced by the following bug in the test, when `USE_PAYMENTS=False` is the default: ``` # A profile should have been created profile = Profile.objects.get() self.assertEqual(profile.sms_limit, 5) self.assertEqual(profile.call_limit, 0) ``` Ref: https://github.com/healthchecks/healthchecks/compare/77ee8452c5f8...8c134570371c#diff-9336213c71d0ba69ae89055c09e2c53aR21-R25

kerem closed this issue

2026-02-25 23:41:58 +03:00

kerem commented

2026-02-25 23:41:59 +03:00

Author

Owner

@cuu508 commented on GitHub (Aug 5, 2020):

Sorry, that's my bad. I have USE_PAYMENTS=True in my local_settings.py and so the tests passed for me. And somehow I missed the Travis notification(s).

Thanks for tracking it down and fixing, @iphoting !

@cuu508 commented on GitHub (Aug 5, 2020): Sorry, that's my bad. I have `USE_PAYMENTS=True` in my `local_settings.py` and so the tests passed for me. And somehow I missed the Travis notification(s). Thanks for tracking it down and fixing, @iphoting !