mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-26 07:25:51 +03:00
[GH-ISSUE #393] Spike.sh integration #300
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#300
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @noob-master147 on GitHub (Jul 7, 2020).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/393
Add integration for Spike.sh
@cuu508 commented on GitHub (Jul 9, 2020):
I'm now testing changes from PR #398. In my testing:
@cuu508 commented on GitHub (Jul 9, 2020):
In the other incident management system integrations, we pass check's code in JSON payload, so the incident management system can look up the right incident. For example, for PagerDuty, we pass a "incident_key" field. It can then look for open incidents with the same key and update them instead of creating a new one. Perhaps something similar be done here as well?
@cuu508 commented on GitHub (Jul 14, 2020):
Consider a scenario:
In this scenario, I expect Spike to look for an existing open incident, but not find it, and therefore ignore the event. But looks like it creates a new incident instead:
How do you match Healthchecks.io notifications to incidents in Spike? Do you extract check names from the notification text? If yes, that has a couple problems:
spike_description.html, the integration will likely breakThe solution is to use a separate field that is immutable and uniquely identifies the check. The PagerDuty integration calls it
incident_key, Opsgenie calls italias, VictorOps calls itentity_id.@noob-master147 commented on GitHub (Jul 14, 2020):
payload = {
"check_id": str(check.code),
"title": tmpl("spike_title.html", check=check),
"message": tmpl("spike_description.html", check=check),
"status": check.status
}
@cuu508 this is what we plan to send now, this will solve the issue that we are facing.
@cuu508 commented on GitHub (Jul 14, 2020):
Added
check_idin the payload, but still the same issue. An "up" notification created a new incident:@noob-master147 commented on GitHub (Jul 14, 2020):
yeah @cuu508 i know, we haven't deployed this update on our server yet, I was just informing you.
@cuu508 commented on GitHub (Jul 15, 2020):
The issue with "up" alerts creating new incidents has been fixed – details in #402