[GH-ISSUE #391] integration stay red until next message is send even if test succeeds #295

Closed
opened 2026-02-25 23:41:56 +03:00 by kerem · 4 comments
Owner

Originally created by @SuperSandro2000 on GitHub (Jun 30, 2020).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/391

I am self hosting my healthchecks and after a connectivity issue a few of my integrations are red. They didn't turn back green when I tested them to see if they are working. I think this should be added cause they should not stay red until the next real alarm is send.

Originally created by @SuperSandro2000 on GitHub (Jun 30, 2020). Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/391 I am self hosting my healthchecks and after a connectivity issue a few of my integrations are red. They didn't turn back green when I tested them to see if they are working. I think this should be added cause they should not stay red until the next real alarm is send.
kerem closed this issue 2026-02-25 23:41:56 +03:00
Author
Owner

@cuu508 commented on GitHub (Jul 1, 2020):

Thanks for the suggestion, makes sense.

I changed how the "Test!" button works:

  • sending test notification now creates a Notification object, same as for normal notifications. Consequently, sending a test notification now updates the "Status" and "Last Notification" columns in the Integrations page:

image

  • sending a test notification now updates (sets or clears) the Channel.last_error field. This is what determines if we show the red exclamation sign in top nav or not.
<!-- gh-comment-id:652356679 --> @cuu508 commented on GitHub (Jul 1, 2020): Thanks for the suggestion, makes sense. I changed how the "Test!" button works: * sending test notification now creates a Notification object, same as for normal notifications. Consequently, sending a test notification now updates the "Status" and "Last Notification" columns in the Integrations page: ![image](https://user-images.githubusercontent.com/661859/86237738-ff458c00-bba4-11ea-8a2e-f97c1380285a.png) * sending a test notification now updates (sets or clears) the Channel.last_error field. This is what determines if we show the red exclamation sign in top nav or not.
Author
Owner

@SuperSandro2000 commented on GitHub (Jul 1, 2020):

Thanks!

Does this also mean both notification are send from the same process?

<!-- gh-comment-id:652372465 --> @SuperSandro2000 commented on GitHub (Jul 1, 2020): Thanks! Does this also mean both notification are send from the same process?
Author
Owner

@cuu508 commented on GitHub (Jul 1, 2020):

No, normal notifications are sent by the manage.py sendalerts process. Test notifications are sent by the web server process while handling the HTTP request.

<!-- gh-comment-id:652374352 --> @cuu508 commented on GitHub (Jul 1, 2020): No, normal notifications are sent by the `manage.py sendalerts` process. Test notifications are sent by the web server process while handling the HTTP request.
Author
Owner

@SuperSandro2000 commented on GitHub (Jul 1, 2020):

Good to clarify that. I noticed this error initially while debugging this.

<!-- gh-comment-id:652380153 --> @SuperSandro2000 commented on GitHub (Jul 1, 2020): Good to clarify that. I noticed this error initially while debugging this.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/healthchecks#295
No description provided.