mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #341] integration editing is awkward #261
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#261
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @robx on GitHub (Mar 10, 2020).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/341
You're probably aware of this, but I thought I'd summarize my experience anyway. I just went through setting up an integration with zulipchat (compare #202) via a custom webhook. That involved a bit of tweaking things, which turned out to be quite painful because
From my outside perspective, the best fix for this would be to allow editing integrations with a form similar to the "create integration" form, and to include the integration name there.
@cuu508 commented on GitHub (Mar 10, 2020):
Thanks for the feedback!
Allowing integrations to be edited definitely makes sense for webhook integrations. All is well when you know precisely what webhook parameters you want. But it's a PITA when you're experimenting and iterating.
Also agree on editing the integration name in the same form.
There's an issue on this already: #176, so I'll comment there and close this one.
@cuu508 commented on GitHub (Apr 6, 2020):
@robx just a heads up – the following is now implemented:
@robx commented on GitHub (Apr 6, 2020):
Sounds awesome, thank you! I'll be sure to test as soon as I need to set up another integration.