mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 15:05:49 +03:00
[GH-ISSUE #334] URL Verification without TLD #255
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#255
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ivanmihov on GitHub (Feb 18, 2020).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/334
Can we adjust the URL verification to allow URLs without the TLD?
My use case is in Docker, where the container is part of an internal network and is given access only to that network. I need to create a Webhook that does a post request to a URL: http://notify/messages
At the moment the UI shows an error "Enter a valid URL" because the TLD is missing, however, the address is still valid.
@cuu508 commented on GitHub (Feb 18, 2020):
Not easily, would require changes in a number of places. And I definitely would not want to copy, modify and maintain the monster regex that Django uses for URL validation.
This is the first time TLD-less webhook addresses have come up. Maybe you can get by with a workaround: edit the webhook address in Django admin > Api > Channels? There's no URL validation there.
@ivanmihov commented on GitHub (Feb 18, 2020):
You are right, it might be too specific of a use case to go through all that.
Your suggestion about editing the Django admin channel worked:) Thank you, I will close the issue now.