mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #286] Edit option on mobile #214
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#214
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alex-phillips on GitHub (Sep 6, 2019).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/286
The mobile view doesn't have any way to enter the edit page of a check. I have to request the desktop site to edit.
@jesse-holden commented on GitHub (Nov 4, 2019):
I believe this is in fact a CSS issue, visiting the page in landscape mode does reveal the edit button to the right.
A suggestion I have would be to add a click event to the entire row, that way if you click between the columns you could go to the details page for that check.
@cuu508 commented on GitHub (Nov 5, 2019):
I "fixed" the mobile view to always show the gear icon. To make room for it, the "Last Ping" column is now hidden in the mobile view.
Thanks for the suggestion about handling clicks on the entire row. Currently, clicking on name brings up the "Edit Name" dialog. And, before I removed the "Last Ping" column, clicking on the last ping area was bringing up another dialog. That leaves very little space for "entire row" click target.