mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #281] Support schedules such as every 85 minutes #211
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#211
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @baragona on GitHub (Aug 27, 2019).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/281
We can set schedules with granularity every minute, up to 60 minutes, then the granularity is 1 hour... So we can't set schedules such as every 80 minutes.
@jesse-holden commented on GitHub (Nov 2, 2019):
You can already achieve granularity by creating/updating checks via API, you can supply the schedules with intervals accurate to the second.
@cuu508 commented on GitHub (Feb 12, 2021):
UI suggestions from @peternlewis on twitter:
@cuu508 commented on GitHub (Nov 3, 2021):
I'm experimenting with UI ideas and considering this one:
Next to the "Period" label there is now an input box. Moving the slider updates the value in the input box. Editing text in the input box updates the slider. The slider range is extended to 365 days so the slider can display something approximately correct when the user enters "60 days" or "90 days". It is not explained in the UI, but the text box would accept three formats:
"60 days" and "86400 minutes" would be equivalent inputs.
PS. In the screenshot, the "Grace Time" section is not updated yet. It would be updated to look and work the same as the "Period" section.
@cuu508 commented on GitHub (Nov 3, 2021):
One part I'm not sure about is the "[number] minutes|hours|days" special syntax. It would need to be documented somewhere, there would be corner cases, and user errors. A more structured alternative:
The user can enter a number, and select minutes / hours / days from the dropdown. This would prevent invalid inputs like "2 months" but would still allow "85 minutes" or "60 days".
@baragona commented on GitHub (Nov 4, 2021):
I like the dropdown a lot.
@cuu508 commented on GitHub (Nov 4, 2021):
I've implemented the initial version, also available on the hosted service now.
For the minutes / hours / days selector I went with the standard
<select>element. Better accessibility and cleaner code compared to bootstrap dropdown.