mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 15:05:49 +03:00
[GH-ISSUE #251] Feature Request: change category badge status to partially down #183
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#183
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BioTheWolff on GitHub (May 9, 2019).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/251
I am doing a status page and made a check fail for test purposes. I saw that if one check is down, all the categories it belongs to are noted "down". Could we add a orange-ish color and a "Partially Down" state if the category has up checks and down checks ?
@cuu508 commented on GitHub (May 14, 2019):
The orange color is currently used to indicate the "in grace period" status. The rules are:
The badges have SVG and JSON versions:
We cannot easily change the behaviour of the SVG badges because people are already relying on their current behaviour. We can, however, add more fields in the JSON ones. Say, instead of returning
return a few more fields:
On the status page side you could then fetch the JSON and format it as a badge or a dashboard widget locally. How does that sound?
@BioTheWolff commented on GitHub (May 14, 2019):
Sounds really great ! In addition to allowing the users to get more informations, you give numbers that can be displayed too ! I like the idea, it is totally the answer i expected. Thanks :p
Tell me if you want to implement it right now or later, i don't care much about the date :)
@cuu508 commented on GitHub (May 15, 2019):
@BioTheWolff I've now deployed this change. Feel free to check it out when you get a chance.
I decided to go with this format:
I used "total" instead of "up", because checks can also be in "new" and "paused" states – it would be inaccurate to count them as "up".