mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #38] unpausing checks that glitch out #17
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#17
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @diwu1989 on GitHub (Jan 29, 2016).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/38
@cuu508 commented on GitHub (Jan 29, 2016):
What I'm planning to do is to get rid of the "stopped" state.
Suppose you have multiple channels set up, let's say an email and a Slack webhook. And the webhook URL is obviously invalid, because of copy-pasting mishap.
What happens currently: the first time we try posting to Slack and fail, we mark the check as "paused" and give up forever. Even though the email channel might still be viable and useful.
What I think should happen: check never goes into "paused" state. If a posting to a channel fails, we store the most recent failure message and display it on "Channels" page, add a note about it in monthly report etc. Failures might also be temporary and it is worth retrying later.
@diwu1989 commented on GitHub (Jan 29, 2016):
yeah deal that sounds way better, i hit a hiccup with slack recently and some of my checks got paused
@cuu508 commented on GitHub (Jan 31, 2016):
This is now implemented: checks don't go into "paused" state. If there is a problem with one of the channels, it will be indicated on "Integrations" page, but rest of the channels still work.