mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #202] Add Zulip integration #143
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#143
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gingerjoos on GitHub (Nov 15, 2018).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/202
Integration with Zulip chat would be useful.
@robx commented on GitHub (Mar 10, 2020):
I needed this too, right now. Managed to set it up manually with a webhook to the zulip message API:
That was a bit of a pain though, and the variable subsitution is unlikely to be robust.
(I couldn't tell whether the linked Apprise PR helps here.)
@cuu508 commented on GitHub (Mar 10, 2020):
The Apprise integration can be optionally enabled on self-hosted Healthchecks instances. It is not enabled on the hosted service (https://healthchecks.io).
I'm open to the idea of adding a Zulip integration. @robx thanks for posting the webhook sample – that's a good starting point for a dedicated integration. I'll experiment with it and see how it goes.
@cuu508 commented on GitHub (Mar 11, 2020):
I've now implemented an experimental Zulip integration, and it is already deployed on https://healthchecks.io
@gingerjoos, @robx feel free to try it out when you get a chance. All feedback welcome!
@JunaidLoonat commented on GitHub (Jan 16, 2021):
Thanks so much @cuu508 but, due to a subdomain mismatch, the current integration does not work correctly with ZulipChat-hosted instances.
As @robx detailed previously, the bot's email address domain is "@zulipchat.com" but the destination Zulip API would be at "myserver.zulipchat.com"
However, HC's current Zulip transport uses the email address to determine the destination Zulip API.
I guess the easiest solution would be to simply ask the user for their Zulip instance's FQDN.
@cuu508 commented on GitHub (Jan 19, 2021):
Thanks for letting me know, @JunaidLoonat !
I changed the "Add Zulip" form to ask for the
zuliprcfile. The zuliprc file contains all three of: bot's email address, API key, and the API endpoint URL.Here's how the form looks now:
@JunaidLoonat commented on GitHub (Jan 24, 2021):
Thanks again @cuu508! This time for the quick update!
I've removed my webhook (for Zulip) because I've confirmed that this new Zulip integration works 👍
Plus, I have no doubt that just using the
zuliprcsimplifies the process for all users.