mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[GH-ISSUE #18] period 1 month #12
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#12
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @marticardus on GitHub (Dec 17, 2015).
Original GitHub issue: https://github.com/healthchecks/healthchecks/issues/18
Hi,
I want to healthchecking some scripts monthly executed, is possible to modify period for this?
Thanks
@cuu508 commented on GitHub (Dec 17, 2015):
Thanks for suggestion!
This is trickier than it first seems. Behind the scenes the app stores period as a number of seconds. For "1 month", the period would not be fixed, it would be 28, 29, 30 or 31 days, depending on current date. So there would be changes how period gets stored in database. I think it's worth doing though.
@marticardus commented on GitHub (Dec 18, 2015):
Hi,
Thanks for your reply, I am aware of this problem.
At this moment, I assume the risk, and interval of 31 days for me are valid if you believe is possible to add this option.
Kind regards
@diwu1989 commented on GitHub (May 16, 2016):
We just hit this usecase too, and I think a 30 days is good enough.
People can use the grace time to make it work for months with 31 days
@cuu508 commented on GitHub (May 18, 2016):
Yes, makes sense to do it the simple way.
@diwu1989 I saw the "1 month" option already added in your branch, so I cherry-picked that and did a bit of refactoring on it.