[PR #1155] [CLOSED] Issue # 1009 email slug group issue3 #1083

New issue

Closed

opened 2026-02-26 00:30:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 00:30:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/1155
Author: @mkyi-bsu
Created: 5/5/2025
Status: ❌ Closed

Base: master ← Head: issue-#-1009-email-slug-group-issue3

📝 Commits (10+)

6cd1994 Merge pull request #1 from healthchecks/master
646d5fc Initial commit
a4c9c4c restored deleted files and refactored to avoid changing data types around -- now passes original tests
f3b8fec changed ping response back to 'OK' and added types to new function parameter
9eb7828 added error handling for bad byte when decoding ping body
b299eb0 writing the keywords parameters from only list
dd6519d added ui for specifying request body keywords, seperate from the email ones
7d46ed8 added missing comma which caused tests to fail
9d1617e testing for the fixed issue!
3eb81fd updated view.py to read the test i have uploaded

📊 Changes

45 files changed (+1789 additions, -372 deletions)

View changed files

➕ .DS_Store (+0 -0)
📝 .github/workflows/coverage.yml (+1 -1)
📝 .github/workflows/mypy.yml (+2 -2)
📝 .github/workflows/tests.yml (+1 -1)
📝 .gitignore (+2 -0)
📝 hc/accounts/models.py (+6 -0)
📝 hc/api/admin.py (+1 -1)
➕ hc/api/migrations/0119_alter_channel_kind.py (+18 -0)
➕ hc/api/migrations/0119_check_failure_keywords_check_success_keywords_and_more.py (+28 -0)
➕ hc/api/migrations/0120_check_req_failure_kw_check_req_start_kw_and_more.py (+28 -0)
➕ hc/api/migrations/0121_merge_20250425_1306.py (+14 -0)
➕ hc/api/migrations/0122_check_max_duration_check_min_duration_ping_duration_and_more.py (+34 -0)
➕ hc/api/migrations/0123_alter_check_slug.py (+18 -0)
📝 hc/api/models.py (+81 -22)
📝 hc/api/tests/test_check_model.py (+81 -0)
📝 hc/api/tests/test_get_check.py (+157 -157)
➕ hc/api/tests/test_ping_checks.py (+104 -0)
📝 hc/api/tests/test_ping_model.py (+65 -9)
📝 hc/api/tests/test_sendreports.py (+26 -1)
📝 hc/api/tests/test_system_checks.py (+1 -1)

...and 25 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/1155 **Author:** [@mkyi-bsu](https://github.com/mkyi-bsu) **Created:** 5/5/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue-#-1009-email-slug-group-issue3` --- ### 📝 Commits (10+) - [`6cd1994`](https://github.com/healthchecks/healthchecks/commit/6cd199496ed66c1f1fccd409bc52f21b29cee2d0) Merge pull request #1 from healthchecks/master - [`646d5fc`](https://github.com/healthchecks/healthchecks/commit/646d5fc78de757278fc63a68bce400cd7a7ebc72) Initial commit - [`a4c9c4c`](https://github.com/healthchecks/healthchecks/commit/a4c9c4c000afc28433b471303755d27000be9cea) restored deleted files and refactored to avoid changing data types around -- now passes original tests - [`f3b8fec`](https://github.com/healthchecks/healthchecks/commit/f3b8fec98d22d7ef21e7300853bba0986d139c6e) changed ping response back to 'OK' and added types to new function parameter - [`9eb7828`](https://github.com/healthchecks/healthchecks/commit/9eb782863d6bec5777379b74d06c95b95fbd1ea5) added error handling for bad byte when decoding ping body - [`b299eb0`](https://github.com/healthchecks/healthchecks/commit/b299eb08e5c17857c6b7f9a3492449ac0388b0c5) writing the keywords parameters from only list - [`dd6519d`](https://github.com/healthchecks/healthchecks/commit/dd6519d33b7f0a23cc1f46c143db433676f5ec27) added ui for specifying request body keywords, seperate from the email ones - [`7d46ed8`](https://github.com/healthchecks/healthchecks/commit/7d46ed8180cc7c52bf83068350a9f82d22d00c67) added missing comma which caused tests to fail - [`9d1617e`](https://github.com/healthchecks/healthchecks/commit/9d1617e4a29ae7bbd957b5a7f1564d9ec70d7ba8) testing for the fixed issue! - [`3eb81fd`](https://github.com/healthchecks/healthchecks/commit/3eb81fdda2f19883b5f7116e0bb3a1ec16ea099a) updated view.py to read the test i have uploaded ### 📊 Changes **45 files changed** (+1789 additions, -372 deletions) <details> <summary>View changed files</summary> ➕ `.DS_Store` (+0 -0) 📝 `.github/workflows/coverage.yml` (+1 -1) 📝 `.github/workflows/mypy.yml` (+2 -2) 📝 `.github/workflows/tests.yml` (+1 -1) 📝 `.gitignore` (+2 -0) 📝 `hc/accounts/models.py` (+6 -0) 📝 `hc/api/admin.py` (+1 -1) ➕ `hc/api/migrations/0119_alter_channel_kind.py` (+18 -0) ➕ `hc/api/migrations/0119_check_failure_keywords_check_success_keywords_and_more.py` (+28 -0) ➕ `hc/api/migrations/0120_check_req_failure_kw_check_req_start_kw_and_more.py` (+28 -0) ➕ `hc/api/migrations/0121_merge_20250425_1306.py` (+14 -0) ➕ `hc/api/migrations/0122_check_max_duration_check_min_duration_ping_duration_and_more.py` (+34 -0) ➕ `hc/api/migrations/0123_alter_check_slug.py` (+18 -0) 📝 `hc/api/models.py` (+81 -22) 📝 `hc/api/tests/test_check_model.py` (+81 -0) 📝 `hc/api/tests/test_get_check.py` (+157 -157) ➕ `hc/api/tests/test_ping_checks.py` (+104 -0) 📝 `hc/api/tests/test_ping_model.py` (+65 -9) 📝 `hc/api/tests/test_sendreports.py` (+26 -1) 📝 `hc/api/tests/test_system_checks.py` (+1 -1) _...and 25 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>