[PR #1116] [CLOSED] Fix allow rid variable to be upper and lowercase #1073

Closed
opened 2026-02-26 00:30:49 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/1116
Author: @wie-niet
Created: 1/21/2025
Status: Closed

Base: masterHead: rid_ignorecase


📝 Commits (1)

  • b8debaa Fix allow RID variable to be upper and lowercase

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 hc/lib/string.py (+1 -1)

📄 Description

Shell scripts with healthchecks to measure execution time using 'rid' were failing on my MacOS (they were created in uppercase instead of lowercase).

With this patch healthcheck now supports 'rid' created with /usr/bin/uuidgen on MacOS.
The uuid.UUID module in python interpret lower and upper case uuids , only the validation in 'hc/lib/string.py' was restricted to only lowercase.

Now it supports both ;-)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/1116 **Author:** [@wie-niet](https://github.com/wie-niet) **Created:** 1/21/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `rid_ignorecase` --- ### 📝 Commits (1) - [`b8debaa`](https://github.com/healthchecks/healthchecks/commit/b8debaaa6475c7c6b36f9a783be59a0a82b7207f) Fix allow RID variable to be upper and lowercase ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `hc/lib/string.py` (+1 -1) </details> ### 📄 Description Shell scripts with healthchecks to measure execution time using 'rid' were failing on my MacOS (they were created in uppercase instead of lowercase). With this patch healthcheck now supports 'rid' created with /usr/bin/uuidgen on MacOS. The uuid.UUID module in python interpret lower and upper case uuids , only the validation in 'hc/lib/string.py' was restricted to only lowercase. Now it supports both ;-) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 00:30:49 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/healthchecks#1073
No description provided.