[PR #930] [MERGED] Fix crash when email host not configured #1042

Closed
opened 2026-02-26 00:30:43 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/930
Author: @marlenekoh
Created: 12/16/2023
Status: Merged
Merged: 12/18/2023
Merged by: @cuu508

Base: masterHead: 920-fix-crash-when-email-host-not-configured


📝 Commits (4)

  • 694f797 Log exception when email host not configured instead of raising assertion error
  • d4ef790 Fix tests
  • be632ef Reset to master
  • 1a1ca89 Check email host before sending email for project invites

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 hc/accounts/models.py (+3 -2)

📄 Description

closes #920
Log an error instead of raising AssertionError when EMAIL_HOST is blank.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/930 **Author:** [@marlenekoh](https://github.com/marlenekoh) **Created:** 12/16/2023 **Status:** ✅ Merged **Merged:** 12/18/2023 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `920-fix-crash-when-email-host-not-configured` --- ### 📝 Commits (4) - [`694f797`](https://github.com/healthchecks/healthchecks/commit/694f79764519667683f21d45df0ce70f7fdd664d) Log exception when email host not configured instead of raising assertion error - [`d4ef790`](https://github.com/healthchecks/healthchecks/commit/d4ef7901806107fe0ef1a290dca1f87fd6be586f) Fix tests - [`be632ef`](https://github.com/healthchecks/healthchecks/commit/be632ef316f728ba0f7c658f97e745377bcdf004) Reset to master - [`1a1ca89`](https://github.com/healthchecks/healthchecks/commit/1a1ca8956d16b7fa61a68c1e9df37cce1791daee) Check email host before sending email for project invites ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `hc/accounts/models.py` (+3 -2) </details> ### 📄 Description closes #920 Log an error instead of raising AssertionError when EMAIL_HOST is blank. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 00:30:43 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/healthchecks#1042
No description provided.