[PR #899] [CLOSED] Prevent auto hiding of the nav bar on Mobile Safari #1037

Closed
opened 2026-02-26 00:30:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/899
Author: @seidnerj
Created: 9/24/2023
Status: Closed

Base: masterHead: master


📝 Commits (1)

  • 4528bd8 Prevent auto hiding of the nav bar on mobile safari. This can create situations in which certain buttons (e.g. ping body modal dialog "OK" button) appears in an area that when clicked raises the nav bar and actually prevents the click.

📊 Changes

1 file changed (+13 additions, -1 deletions)

View changed files

📝 static/css/base.css (+13 -1)

📄 Description

This can create situations in which certain buttons (e.g. ping body modal dialog "Got It!" button) appear in an area that is essentially un-clickable. When one clicks in that area, safari raises the nav bar and the underlaying button click does not happen (see attached screen recording as an example trying to click the "Got It!" button, top of the screen was cropped in order to remove potentially sensitive details)

https://github.com/healthchecks/healthchecks/assets/4147381/47ea3089-cc64-4a52-8bd7-3e7cce42ec87

I did check this commit on Safari (macOS 14/iOS 17.0.1), but am not sure how to test this thoroughly across multiple browsers and versions. Would appreciate some help/guidance on this.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/899 **Author:** [@seidnerj](https://github.com/seidnerj) **Created:** 9/24/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`4528bd8`](https://github.com/healthchecks/healthchecks/commit/4528bd8f212a4dd01b8bc64c295be9154f5e0935) Prevent auto hiding of the nav bar on mobile safari. This can create situations in which certain buttons (e.g. ping body modal dialog "OK" button) appears in an area that when clicked raises the nav bar and actually prevents the click. ### 📊 Changes **1 file changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `static/css/base.css` (+13 -1) </details> ### 📄 Description This can create situations in which certain buttons (e.g. ping body modal dialog "Got It!" button) appear in an area that is essentially un-clickable. When one clicks in that area, safari raises the nav bar and the underlaying button click does not happen (see attached screen recording as an example trying to click the "Got It!" button, top of the screen was cropped in order to remove potentially sensitive details) https://github.com/healthchecks/healthchecks/assets/4147381/47ea3089-cc64-4a52-8bd7-3e7cce42ec87 I did check this commit on Safari (macOS 14/iOS 17.0.1), but am not sure how to test this thoroughly across multiple browsers and versions. Would appreciate some help/guidance on this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 00:30:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/healthchecks#1037
No description provided.