mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 15:05:49 +03:00
[PR #899] [CLOSED] Prevent auto hiding of the nav bar on Mobile Safari #1037
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#1037
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/healthchecks/healthchecks/pull/899
Author: @seidnerj
Created: 9/24/2023
Status: ❌ Closed
Base:
master← Head:master📝 Commits (1)
4528bd8Prevent auto hiding of the nav bar on mobile safari. This can create situations in which certain buttons (e.g. ping body modal dialog "OK" button) appears in an area that when clicked raises the nav bar and actually prevents the click.📊 Changes
1 file changed (+13 additions, -1 deletions)
View changed files
📝
static/css/base.css(+13 -1)📄 Description
This can create situations in which certain buttons (e.g. ping body modal dialog "Got It!" button) appear in an area that is essentially un-clickable. When one clicks in that area, safari raises the nav bar and the underlaying button click does not happen (see attached screen recording as an example trying to click the "Got It!" button, top of the screen was cropped in order to remove potentially sensitive details)
https://github.com/healthchecks/healthchecks/assets/4147381/47ea3089-cc64-4a52-8bd7-3e7cce42ec87
I did check this commit on Safari (macOS 14/iOS 17.0.1), but am not sure how to test this thoroughly across multiple browsers and versions. Would appreciate some help/guidance on this.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.