[PR #735] [MERGED] Add body to Slack Notification #1018

Closed
opened 2026-02-26 00:30:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/735
Author: @s256
Created: 11/17/2022
Status: Merged
Merged: 11/22/2022
Merged by: @cuu508

Base: masterHead: master


📝 Commits (4)

  • 601dbf6 add body to slack notification
  • c8acf7c append trailing comma only if there is another element
  • c21dac1 Add 1000 character limit for last ping body in slack notifications
  • d51a46d Add tests

📊 Changes

3 files changed (+89 additions, -39 deletions)

View changed files

📝 hc/api/tests/test_notify_slack.py (+35 -0)
📝 hc/api/transports.py (+3 -2)
📝 templates/integrations/slack_message.json (+51 -37)

📄 Description

We were missing the body / payload of the last request triggering a notification.
Hence we added the body to the template, if it exists.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/735 **Author:** [@s256](https://github.com/s256) **Created:** 11/17/2022 **Status:** ✅ Merged **Merged:** 11/22/2022 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`601dbf6`](https://github.com/healthchecks/healthchecks/commit/601dbf69066a88ed67252ce5522d3981b8e3136c) add body to slack notification - [`c8acf7c`](https://github.com/healthchecks/healthchecks/commit/c8acf7cd1ad4848413f412fcf3c7e16a15b6e11b) append trailing comma only if there is another element - [`c21dac1`](https://github.com/healthchecks/healthchecks/commit/c21dac1bac409b5e89ccf588c079b99f8bf60a02) Add 1000 character limit for last ping body in slack notifications - [`d51a46d`](https://github.com/healthchecks/healthchecks/commit/d51a46d7d2b4bea8fbcd7cdc1fb4b98b77e0bfd6) Add tests ### 📊 Changes **3 files changed** (+89 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `hc/api/tests/test_notify_slack.py` (+35 -0) 📝 `hc/api/transports.py` (+3 -2) 📝 `templates/integrations/slack_message.json` (+51 -37) </details> ### 📄 Description We were missing the body / payload of the last request triggering a notification. Hence we added the body to the template, if it exists. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 00:30:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/healthchecks#1018
No description provided.