mirror of
https://github.com/healthchecks/healthchecks.git
synced 2026-04-25 06:55:53 +03:00
[PR #735] [MERGED] Add body to Slack Notification #1018
Labels
No labels
bug
bug
bug
feature
good-first-issue
new integration
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/healthchecks#1018
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/healthchecks/healthchecks/pull/735
Author: @s256
Created: 11/17/2022
Status: ✅ Merged
Merged: 11/22/2022
Merged by: @cuu508
Base:
master← Head:master📝 Commits (4)
601dbf6add body to slack notificationc8acf7cappend trailing comma only if there is another elementc21dac1Add 1000 character limit for last ping body in slack notificationsd51a46dAdd tests📊 Changes
3 files changed (+89 additions, -39 deletions)
View changed files
📝
hc/api/tests/test_notify_slack.py(+35 -0)📝
hc/api/transports.py(+3 -2)📝
templates/integrations/slack_message.json(+51 -37)📄 Description
We were missing the body / payload of the last request triggering a notification.
Hence we added the body to the template, if it exists.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.