[PR #720] [MERGED] Added duration to ping details #1013

New issue

Closed

opened 2026-02-26 00:30:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 00:30:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/healthchecks/healthchecks/pull/720
Author: @seidnerj
Created: 10/24/2022
Status: ✅ Merged
Merged: 11/1/2022
Merged by: @cuu508

Base: master ← Head: master

📝 Commits (7)

4d6e101 Added duration to ping details. This is useful on a device with a small screen, since the duration cannot be seen in the main view so now one can see it in the ping's details.
b10550c Added duration to ping details. This is useful on a device with a small screen, since the duration cannot be seen in the main view so now one can see it in the ping's details.
bf4a244 fixed - added duration to ping details
5daac42 added missing typing information for ping.get_delta()
16893e5 1. ping.get_delta() --> ping.duration (cached property)
8f97e34 added an appropriate test under "test_ping_details.py"
aedf3ea Merge branch 'healthchecks:master' into master

📊 Changes

21 files changed (+120 additions, -68 deletions)

View changed files

📝 hc/accounts/management/commands/pruneusers.py (+2 -2)
📝 hc/accounts/management/commands/senddeletionnotices.py (+2 -2)
📝 hc/accounts/migrations/0012_auto_20171014_1002.py (+5 -5)
📝 hc/accounts/models.py (+7 -7)
📝 hc/accounts/tests/test_pruneusers.py (+2 -2)
📝 hc/api/management/commands/prunetokenbucket.py (+2 -2)
📝 hc/api/migrations/0002_auto_20150616_0732.py (+13 -13)
📝 hc/api/migrations/0003_auto_20150616_1249.py (+2 -2)
📝 hc/api/migrations/0006_check_grace.py (+2 -2)
📝 hc/api/models.py (+27 -10)
📝 hc/api/tests/test_notification_status.py (+2 -2)
📝 hc/api/views.py (+4 -4)
📝 hc/front/tests/test_my_checks.py (+2 -2)
📝 hc/front/tests/test_ping_details.py (+16 -0)
📝 hc/front/views.py (+4 -4)
📝 static/css/log.css (+2 -2)
📝 templates/docs/measuring_script_run_time.html (+2 -2)
📝 templates/docs/measuring_script_run_time.md (+2 -2)
📝 templates/front/details_downtimes.html (+2 -2)
📝 templates/front/log_row.html (+1 -1)

...and 1 more files

📄 Description

This is useful on devices that have a small screen, since the duration cannot be seen in the main view. With this, one can see the duration in the ping's details.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/healthchecks/healthchecks/pull/720 **Author:** [@seidnerj](https://github.com/seidnerj) **Created:** 10/24/2022 **Status:** ✅ Merged **Merged:** 11/1/2022 **Merged by:** [@cuu508](https://github.com/cuu508) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`4d6e101`](https://github.com/healthchecks/healthchecks/commit/4d6e101a454bbbefc5bb28daf43f26ff95f14d93) Added duration to ping details. This is useful on a device with a small screen, since the duration cannot be seen in the main view so now one can see it in the ping's details. - [`b10550c`](https://github.com/healthchecks/healthchecks/commit/b10550ca5973d03127735e2c614a00891e3ae1ca) Added duration to ping details. This is useful on a device with a small screen, since the duration cannot be seen in the main view so now one can see it in the ping's details. - [`bf4a244`](https://github.com/healthchecks/healthchecks/commit/bf4a2446feca4c430e19db9b520abadfb2c0b3b9) fixed - added duration to ping details - [`5daac42`](https://github.com/healthchecks/healthchecks/commit/5daac424dcbcc88c2755c3403edfa06339955f99) added missing typing information for ping.get_delta() - [`16893e5`](https://github.com/healthchecks/healthchecks/commit/16893e501916e0509e1ab8e5095b14d4e8bc3432) 1. ping.get_delta() --> ping.duration (cached property) - [`8f97e34`](https://github.com/healthchecks/healthchecks/commit/8f97e347263d9da682df3301962d8eb5138e392b) added an appropriate test under "test_ping_details.py" - [`aedf3ea`](https://github.com/healthchecks/healthchecks/commit/aedf3ea9d6514485d9b9da354cc6ff44c13d381c) Merge branch 'healthchecks:master' into master ### 📊 Changes **21 files changed** (+120 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `hc/accounts/management/commands/pruneusers.py` (+2 -2) 📝 `hc/accounts/management/commands/senddeletionnotices.py` (+2 -2) 📝 `hc/accounts/migrations/0012_auto_20171014_1002.py` (+5 -5) 📝 `hc/accounts/models.py` (+7 -7) 📝 `hc/accounts/tests/test_pruneusers.py` (+2 -2) 📝 `hc/api/management/commands/prunetokenbucket.py` (+2 -2) 📝 `hc/api/migrations/0002_auto_20150616_0732.py` (+13 -13) 📝 `hc/api/migrations/0003_auto_20150616_1249.py` (+2 -2) 📝 `hc/api/migrations/0006_check_grace.py` (+2 -2) 📝 `hc/api/models.py` (+27 -10) 📝 `hc/api/tests/test_notification_status.py` (+2 -2) 📝 `hc/api/views.py` (+4 -4) 📝 `hc/front/tests/test_my_checks.py` (+2 -2) 📝 `hc/front/tests/test_ping_details.py` (+16 -0) 📝 `hc/front/views.py` (+4 -4) 📝 `static/css/log.css` (+2 -2) 📝 `templates/docs/measuring_script_run_time.html` (+2 -2) 📝 `templates/docs/measuring_script_run_time.md` (+2 -2) 📝 `templates/front/details_downtimes.html` (+2 -2) 📝 `templates/front/log_row.html` (+1 -1) _...and 1 more files_ </details> ### 📄 Description This is useful on devices that have a small screen, since the duration cannot be seen in the main view. With this, one can see the duration in the ping's details. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>