[PR #85] [MERGED] Voting support follow-ups #98

New issue

Closed

opened 2026-03-14 12:32:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:32:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/85
Author: @aome510
Created: 2/2/2023
Status: ✅ Merged
Merged: 2/3/2023
Merged by: @aome510

Base: main ← Head: implement-vote-vis

📝 Commits (10+)

3fffa23 use HnItem::text method to get the item's text depending on its state
9dc015a update item's display text after voting
c2595cf avoid delay when voting
0ca8700 fix collapsed item's children not hidden bug
28cfbeb handle multi-page story when getting its page content
a19738c parallize get story's page content and its comments
4a2e604 add documentation for vote command
f607df6 add authentication documentation
21d0c27 hyperlink "authentication" in vote command's description
ff13b66 cleanup

📊 Changes

7 files changed (+160 additions, -68 deletions)

View changed files

📝 README.md (+29 -16)
📝 hackernews_tui/src/client/mod.rs (+34 -4)
📝 hackernews_tui/src/model.rs (+28 -8)
📝 hackernews_tui/src/utils.rs (+11 -5)
📝 hackernews_tui/src/view/async_view.rs (+2 -2)
📝 hackernews_tui/src/view/comment_view.rs (+46 -29)
📝 hackernews_tui/src/view/help_view.rs (+10 -4)

📄 Description

Changes

added voting visualization
handled voting command asynchronously to avoid blocking
fixed bug (from #84) that made collapsed item's children not hidden
handled multi-paged stories when getting story's
added authentication/voting documentations

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/85 **Author:** [@aome510](https://github.com/aome510) **Created:** 2/2/2023 **Status:** ✅ Merged **Merged:** 2/3/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `implement-vote-vis` --- ### 📝 Commits (10+) - [`3fffa23`](https://github.com/aome510/hackernews-TUI/commit/3fffa23731b82b85688b1e0f2c07f34f83ee74f1) use `HnItem::text` method to get the item's text depending on its state - [`9dc015a`](https://github.com/aome510/hackernews-TUI/commit/9dc015a3f469c3ad03a04018e1e813242d90098b) update item's display text after voting - [`c2595cf`](https://github.com/aome510/hackernews-TUI/commit/c2595cf9db1155d718f6421359ae11c8c06ab220) avoid delay when voting - [`0ca8700`](https://github.com/aome510/hackernews-TUI/commit/0ca8700ce11788a8eb7cf49b7fb4551309e15c58) fix collapsed item's children not hidden bug - [`28cfbeb`](https://github.com/aome510/hackernews-TUI/commit/28cfbeb0bf01597e968de6ea45bc2321ccace918) handle multi-page story when getting its page content - [`a19738c`](https://github.com/aome510/hackernews-TUI/commit/a19738c2e9a99443db7e149ebfbbb16d516b4945) parallize get story's page content and its comments - [`4a2e604`](https://github.com/aome510/hackernews-TUI/commit/4a2e604bfff02ff016c0f2d5ca240bc534d85a18) add documentation for `vote` command - [`f607df6`](https://github.com/aome510/hackernews-TUI/commit/f607df6b434b5df34a0efad7a9024d20b3eb263a) add authentication documentation - [`21d0c27`](https://github.com/aome510/hackernews-TUI/commit/21d0c272b47584ec677e400eaf339ce7379ec33d) hyperlink "authentication" in vote command's description - [`ff13b66`](https://github.com/aome510/hackernews-TUI/commit/ff13b66451a58065a766b8792f8cd1423c95d86e) cleanup ### 📊 Changes **7 files changed** (+160 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+29 -16) 📝 `hackernews_tui/src/client/mod.rs` (+34 -4) 📝 `hackernews_tui/src/model.rs` (+28 -8) 📝 `hackernews_tui/src/utils.rs` (+11 -5) 📝 `hackernews_tui/src/view/async_view.rs` (+2 -2) 📝 `hackernews_tui/src/view/comment_view.rs` (+46 -29) 📝 `hackernews_tui/src/view/help_view.rs` (+10 -4) </details> ### 📄 Description ## Changes - added voting visualization - handled voting command asynchronously to avoid blocking - fixed bug (from #84) that made collapsed item's children not hidden - handled multi-paged stories when getting story's - added authentication/voting documentations --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>