[PR #90] [MERGED] Support opening specific comment view on startup #96

New issue

Closed

opened 2026-03-14 12:32:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:32:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/90
Author: @aome510
Created: 4/24/2023
Status: ✅ Merged
Merged: 4/24/2023
Merged by: @aome510

Base: main ← Head: support-comment-view-on-startup

📝 Commits (6)

c292970 add start_id cli option
58045b8 use "item" instead of "story" to represent the root item of a HackerNews page
03af9c8 update comment view codes to construct the view from page data
d98c26d handle comment_view_keymap.open_story_in_browser correctly
49606d5 cleanup comments/documentations
9123455 fix clippy error

📊 Changes

9 files changed (+162 additions, -94 deletions)

View changed files

📝 hackernews_tui/src/client/mod.rs (+72 -32)
📝 hackernews_tui/src/client/model.rs (+15 -2)
📝 hackernews_tui/src/main.rs (+11 -3)
📝 hackernews_tui/src/model.rs (+12 -1)
📝 hackernews_tui/src/view/async_view.rs (+4 -7)
📝 hackernews_tui/src/view/comment_view.rs (+24 -35)
📝 hackernews_tui/src/view/fn_view_wrapper.rs (+1 -1)
📝 hackernews_tui/src/view/mod.rs (+21 -11)
📝 hackernews_tui/src/view/story_view.rs (+2 -2)

📄 Description

Resolves #86

Changes

added -i cli option to open the application in a specific comment view
updated comment view codes to
- not require a story to construct a comment view
- allow constructing a comment view of either a comment or a story

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/90 **Author:** [@aome510](https://github.com/aome510) **Created:** 4/24/2023 **Status:** ✅ Merged **Merged:** 4/24/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `support-comment-view-on-startup` --- ### 📝 Commits (6) - [`c292970`](https://github.com/aome510/hackernews-TUI/commit/c29297086a126128f65cbdcfc59603ca14725a74) add `start_id` cli option - [`58045b8`](https://github.com/aome510/hackernews-TUI/commit/58045b895fb10688965509c31c6bd85f19ec5576) use "item" instead of "story" to represent the root item of a HackerNews page - [`03af9c8`](https://github.com/aome510/hackernews-TUI/commit/03af9c83fe4de72df6532f7f2fa40f891766ec0d) update comment view codes to construct the view from page data - [`d98c26d`](https://github.com/aome510/hackernews-TUI/commit/d98c26d6e5673dd5b6625f24d2be322aa91e6e66) handle `comment_view_keymap.open_story_in_browser` correctly - [`49606d5`](https://github.com/aome510/hackernews-TUI/commit/49606d57e5460b5193d3bb72e0336baaf709973e) cleanup comments/documentations - [`9123455`](https://github.com/aome510/hackernews-TUI/commit/9123455ee97e959b2bc0c267d5306515886ae920) fix clippy error ### 📊 Changes **9 files changed** (+162 additions, -94 deletions) <details> <summary>View changed files</summary> 📝 `hackernews_tui/src/client/mod.rs` (+72 -32) 📝 `hackernews_tui/src/client/model.rs` (+15 -2) 📝 `hackernews_tui/src/main.rs` (+11 -3) 📝 `hackernews_tui/src/model.rs` (+12 -1) 📝 `hackernews_tui/src/view/async_view.rs` (+4 -7) 📝 `hackernews_tui/src/view/comment_view.rs` (+24 -35) 📝 `hackernews_tui/src/view/fn_view_wrapper.rs` (+1 -1) 📝 `hackernews_tui/src/view/mod.rs` (+21 -11) 📝 `hackernews_tui/src/view/story_view.rs` (+2 -2) </details> ### 📄 Description Resolves #86 ## Changes - added `-i` cli option to open the application in a specific comment view - updated comment view codes to + not require a story to construct a comment view + allow constructing a comment view of either a comment or a story --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>