[PR #60] [MERGED] Integrate `comfy_table` #77

New issue

Closed

opened 2026-03-14 12:30:56 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:30:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/60
Author: @aome510
Created: 12/28/2021
Status: ✅ Merged
Merged: 12/28/2021
Merged by: @aome510

Base: main ← Head: integrate-comfy-table

📝 Commits (7)

cf272c0 implement a table renderer using comfy_table
de6ff87 Merge branch 'main' into integrate-comfy-table
d962829 finetune the look of the rendered table
900dee9 render the html table based on the view's width
60cfb55 allow clippy::too_many_arguments in Article::parse_dom_node
942742b improve error handling and documentation
0b2faee fix cargo fmt error

📊 Changes

5 files changed (+215 additions, -16 deletions)

View changed files

📝 Cargo.lock (+78 -2)
📝 hackernews_tui/Cargo.toml (+1 -0)
📝 hackernews_tui/src/client/mod.rs (+0 -1)
📝 hackernews_tui/src/client/parser.rs (+102 -6)
📝 hackernews_tui/src/view/article_view.rs (+34 -7)

📄 Description

Brief description of changes

use comfy_table to render HTML table as text
re-parse the article if the view's width has changed since the last render

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/60 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/28/2021 **Status:** ✅ Merged **Merged:** 12/28/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `integrate-comfy-table` --- ### 📝 Commits (7) - [`cf272c0`](https://github.com/aome510/hackernews-TUI/commit/cf272c08f7ccb5c3db54cd3cbeb9dbcc080d1c76) implement a table renderer using `comfy_table` - [`de6ff87`](https://github.com/aome510/hackernews-TUI/commit/de6ff87e09bd5edf5c04c24e94d7f80043afef63) Merge branch 'main' into integrate-comfy-table - [`d962829`](https://github.com/aome510/hackernews-TUI/commit/d962829eb5e3a852bea65a76020bed88641912f7) finetune the look of the rendered table - [`900dee9`](https://github.com/aome510/hackernews-TUI/commit/900dee93d12415f59ae00c4a146a3a30cc8e5fcb) render the html table based on the view's width - [`60cfb55`](https://github.com/aome510/hackernews-TUI/commit/60cfb55e7cfb71056cabdb2f74933314a8104cf7) allow `clippy::too_many_arguments` in `Article::parse_dom_node` - [`942742b`](https://github.com/aome510/hackernews-TUI/commit/942742b5129194223e637dd3a10c09af018c78f7) improve error handling and documentation - [`0b2faee`](https://github.com/aome510/hackernews-TUI/commit/0b2faee467816605dc8d1efa4706bdd10794fcf4) fix cargo fmt error ### 📊 Changes **5 files changed** (+215 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+78 -2) 📝 `hackernews_tui/Cargo.toml` (+1 -0) 📝 `hackernews_tui/src/client/mod.rs` (+0 -1) 📝 `hackernews_tui/src/client/parser.rs` (+102 -6) 📝 `hackernews_tui/src/view/article_view.rs` (+34 -7) </details> ### 📄 Description ## Brief description of changes - use [`comfy_table`](https://github.com/Nukesor/comfy-table) to render HTML table as text - re-parse the article if the view's width has changed since the last render --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>