[PR #53] [MERGED] Add a client logger #73

New issue

Closed

opened 2026-03-14 12:30:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:30:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/53
Author: @aome510
Created: 12/14/2021
Status: ✅ Merged
Merged: 12/14/2021
Merged by: @aome510

Base: main ← Head: add-client-logger

📝 Commits (5)

d8803bc preserve the comment order in load_comments
2a609ef use log macro to record API response time
b867591 add limit for the number of comments updated each time
04ba05c mention shortcuts are customizable in Default Shortcuts section
eaf244e make the log message more descriptive

📊 Changes

3 files changed (+89 additions, -87 deletions)

View changed files

📝 README.md (+1 -1)
📝 hackernews_tui/src/client/mod.rs (+84 -85)
📝 hackernews_tui/src/view/comment_view.rs (+4 -1)

📄 Description

Brief description of changes

add a client logger to record API response time
preserve the initial comment order in Client::load_comments
limit the number of updated comments in each CommentView::try_update_comments call

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/53 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/14/2021 **Status:** ✅ Merged **Merged:** 12/14/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `add-client-logger` --- ### 📝 Commits (5) - [`d8803bc`](https://github.com/aome510/hackernews-TUI/commit/d8803bcf72a700d5d5f10d633d331ef7d458b92c) preserve the comment order in `load_comments` - [`2a609ef`](https://github.com/aome510/hackernews-TUI/commit/2a609ef42eee41cad67aef4251aed4f82753c5b7) use `log` macro to record API response time - [`b867591`](https://github.com/aome510/hackernews-TUI/commit/b867591423a69bacc9e7b9c587e62b91b9943f60) add `limit` for the number of comments updated each time - [`04ba05c`](https://github.com/aome510/hackernews-TUI/commit/04ba05ccb7067ba5dc4c428bd4dee4769f96126c) mention shortcuts are customizable in Default Shortcuts section - [`eaf244e`](https://github.com/aome510/hackernews-TUI/commit/eaf244e6239428888148f2589db56670096b93ab) make the log message more descriptive ### 📊 Changes **3 files changed** (+89 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `hackernews_tui/src/client/mod.rs` (+84 -85) 📝 `hackernews_tui/src/view/comment_view.rs` (+4 -1) </details> ### 📄 Description ## Brief description of changes - add a client logger to record API response time - preserve the initial comment order in `Client::load_comments` - limit the number of updated comments in each `CommentView::try_update_comments` call --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>