[PR #48] [MERGED] Rewrite search view handlers #69

New issue

Closed

opened 2026-03-14 12:30:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:30:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/48
Author: @aome510
Created: 12/10/2021
Status: ✅ Merged
Merged: 12/11/2021
Merged by: @aome510

Base: improve-shortcut-handlers ← Head: exp-rewrite-search-view-handlers

📝 Commits (8)

57334d5 add parking_lot
a4ff5fd rewrite matched stories retrieval/update handlers
a948f06 use a StoryView with event handlers in SearchView
f7d2f15 use a cursor effect for EditableTextView only when being focused
cec8223 remove debug loggings
8c346af handle paging/filtering commands for Search View
4c26ba6 add more documentations
8175225 change the visibility of structs/enums in search_view.rs

📊 Changes

5 files changed (+170 additions, -248 deletions)

View changed files

📝 Cargo.lock (+1 -0)
📝 hackernews_tui/Cargo.toml (+1 -0)
📝 hackernews_tui/src/client/mod.rs (+2 -1)
📝 hackernews_tui/src/view/search_view.rs (+159 -246)
📝 hackernews_tui/src/view/text_view.rs (+7 -1)

📄 Description

Rewrite search view handlers:

simplify matched stories retrieval, update, re-render progress (switch from locking to message passing)
simplify handler codes
remove progress bar in search view

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/48 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/10/2021 **Status:** ✅ Merged **Merged:** 12/11/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `improve-shortcut-handlers` ← **Head:** `exp-rewrite-search-view-handlers` --- ### 📝 Commits (8) - [`57334d5`](https://github.com/aome510/hackernews-TUI/commit/57334d576cfe98a8fa315d5e990eb54e5dd71447) add `parking_lot` - [`a4ff5fd`](https://github.com/aome510/hackernews-TUI/commit/a4ff5fd5f1a79d840366ce3924e7609ebbcc32b4) rewrite matched stories retrieval/update handlers - [`a948f06`](https://github.com/aome510/hackernews-TUI/commit/a948f06488e6f1261849a929ff014a9fb9cb1e5b) use a `StoryView` with event handlers in `SearchView` - [`f7d2f15`](https://github.com/aome510/hackernews-TUI/commit/f7d2f151a03a20372d32236478698d4d297a12c9) use a cursor effect for `EditableTextView` only when being focused - [`cec8223`](https://github.com/aome510/hackernews-TUI/commit/cec82236666b9c61be7b96fe3583c978123cc36c) remove debug loggings - [`8c346af`](https://github.com/aome510/hackernews-TUI/commit/8c346af4a7673368730129f007807dade874795e) handle paging/filtering commands for Search View - [`4c26ba6`](https://github.com/aome510/hackernews-TUI/commit/4c26ba6f66078fd8adc1a9bc99c01a7c7f85f363) add more documentations - [`8175225`](https://github.com/aome510/hackernews-TUI/commit/8175225d9777c515217fcc85f3fee94a153ea666) change the visibility of structs/enums in `search_view.rs` ### 📊 Changes **5 files changed** (+170 additions, -248 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+1 -0) 📝 `hackernews_tui/Cargo.toml` (+1 -0) 📝 `hackernews_tui/src/client/mod.rs` (+2 -1) 📝 `hackernews_tui/src/view/search_view.rs` (+159 -246) 📝 `hackernews_tui/src/view/text_view.rs` (+7 -1) </details> ### 📄 Description Rewrite search view handlers: - simplify matched stories retrieval, update, re-render progress (switch from locking to message passing) - simplify handler codes - remove progress bar in search view --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>