[PR #47] [MERGED] Add general improvements #67

New issue

Closed

opened 2026-03-14 12:30:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:30:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/47
Author: @aome510
Created: 11/16/2021
Status: ✅ Merged
Merged: 11/16/2021
Merged by: @aome510

Base: main ← Head: add-general-improvements

📝 Commits (10+)

6b9450a remove release profile
83a373c remove --example-config option
cb86aec simplify load config codes
9dadce2 add tracing and use a file logger
bfbe47a cleanup main.rs
0fab552 remove reload_comment_view shortcut and its handler functions
2095fd4 wip
e6e1170 move comment parsing codes from comment_view.rs to client/parser.rs
26d222e implement better lazy loading comments
e74a986 simplify imports

📊 Changes

24 files changed (+676 additions, -827 deletions)

View changed files

📝 Cargo.lock (+200 -124)
📝 Cargo.toml (+0 -5)
📝 README.md (+0 -1)
📝 config_parser/src/lib.rs (+1 -1)
📝 examples/hn-tui.toml (+0 -12)
📝 hackernews_tui/Cargo.toml (+8 -6)
➖ hackernews_tui/src/client/lazy.rs (+0 -79)
📝 hackernews_tui/src/client/mod.rs (+49 -23)
📝 hackernews_tui/src/client/parser.rs (+137 -37)
📝 hackernews_tui/src/client/query.rs (+1 -1)
📝 hackernews_tui/src/config/keybindings.rs (+0 -2)
📝 hackernews_tui/src/config/mod.rs (+36 -32)
📝 hackernews_tui/src/main.rs (+51 -55)
📝 hackernews_tui/src/prelude.rs (+2 -11)
📝 hackernews_tui/src/utils.rs (+8 -18)
📝 hackernews_tui/src/view/article_view.rs (+22 -26)
📝 hackernews_tui/src/view/async_view.rs (+21 -44)
📝 hackernews_tui/src/view/comment_view.rs (+69 -286)
📝 hackernews_tui/src/view/error_view.rs (+3 -2)
📝 hackernews_tui/src/view/help_view.rs (+29 -33)

...and 4 more files

📄 Description

Brief description of changes

implement a better lazy loading logic for story's comments
move comment parsing codes from view/comment_view.rs to client/parser.rs
add file logger with tracing
simplify codes in async_view by removing request retry
clean crate::prelude
remove release profile
remove reload comment view command
remove allow_unicode config option

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/47 **Author:** [@aome510](https://github.com/aome510) **Created:** 11/16/2021 **Status:** ✅ Merged **Merged:** 11/16/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `add-general-improvements` --- ### 📝 Commits (10+) - [`6b9450a`](https://github.com/aome510/hackernews-TUI/commit/6b9450a1ca2018f1552fd291b2429edc3e084c75) remove release profile - [`83a373c`](https://github.com/aome510/hackernews-TUI/commit/83a373c92c6d6b0d4216f5359dd8f81881913105) remove --example-config option - [`cb86aec`](https://github.com/aome510/hackernews-TUI/commit/cb86aecef6b3a00264115988f4285a70e7f6de44) simplify load config codes - [`9dadce2`](https://github.com/aome510/hackernews-TUI/commit/9dadce2f535ea1ae39caf9322407b2cd3dfb8677) add `tracing` and use a file logger - [`bfbe47a`](https://github.com/aome510/hackernews-TUI/commit/bfbe47a638728ae68e2913ed0662873491f64086) cleanup `main.rs` - [`0fab552`](https://github.com/aome510/hackernews-TUI/commit/0fab5522de384c1d6958e86345d9493362149745) remove `reload_comment_view` shortcut and its handler functions - [`2095fd4`](https://github.com/aome510/hackernews-TUI/commit/2095fd4f14e0b0f1560ff97507ab1eac452489d5) wip - [`e6e1170`](https://github.com/aome510/hackernews-TUI/commit/e6e1170d1a89add0f3c5bcf226d6a1a376eff33c) move comment parsing codes from `comment_view.rs` to `client/parser.rs` - [`26d222e`](https://github.com/aome510/hackernews-TUI/commit/26d222e363f1362895b5600cbdfa9afa4a4b665e) implement better lazy loading comments - [`e74a986`](https://github.com/aome510/hackernews-TUI/commit/e74a986a153ba0d515360255bee86142c3020d97) simplify imports ### 📊 Changes **24 files changed** (+676 additions, -827 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+200 -124) 📝 `Cargo.toml` (+0 -5) 📝 `README.md` (+0 -1) 📝 `config_parser/src/lib.rs` (+1 -1) 📝 `examples/hn-tui.toml` (+0 -12) 📝 `hackernews_tui/Cargo.toml` (+8 -6) ➖ `hackernews_tui/src/client/lazy.rs` (+0 -79) 📝 `hackernews_tui/src/client/mod.rs` (+49 -23) 📝 `hackernews_tui/src/client/parser.rs` (+137 -37) 📝 `hackernews_tui/src/client/query.rs` (+1 -1) 📝 `hackernews_tui/src/config/keybindings.rs` (+0 -2) 📝 `hackernews_tui/src/config/mod.rs` (+36 -32) 📝 `hackernews_tui/src/main.rs` (+51 -55) 📝 `hackernews_tui/src/prelude.rs` (+2 -11) 📝 `hackernews_tui/src/utils.rs` (+8 -18) 📝 `hackernews_tui/src/view/article_view.rs` (+22 -26) 📝 `hackernews_tui/src/view/async_view.rs` (+21 -44) 📝 `hackernews_tui/src/view/comment_view.rs` (+69 -286) 📝 `hackernews_tui/src/view/error_view.rs` (+3 -2) 📝 `hackernews_tui/src/view/help_view.rs` (+29 -33) _...and 4 more files_ </details> ### 📄 Description ## Brief description of changes - implement a better lazy loading logic for story's comments - move comment parsing codes from `view/comment_view.rs` to `client/parser.rs` - add file logger with `tracing` - simplify codes in `async_view` by removing request retry - clean `crate::prelude` - remove release profile - remove reload comment view command - remove `allow_unicode` config option --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>