[PR #39] [MERGED] Implement `config_parser` crates to allow optional configurations #63

New issue

Closed

opened 2026-03-14 12:30:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:30:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/39
Author: @aome510
Created: 6/9/2021
Status: ✅ Merged
Merged: 6/12/2021
Merged by: @aome510

Base: main ← Head: add-config-parser

📝 Commits (10+)

216b4c2 move lazy_loading_comments to client config option
a0220ef move binary package to hackernews_tui folder
0206fd7 implement proc_macro for config_parser in config_parser_derive lib crate
55a407b implement config_parser
4f3d496 use workspaces with multiple crates instead of single binary crate
cc2f46c integrate ConfigParser trait and macros into the binary crate
21d0f3d use config_parser when reading from a config file
4f39dc6 add more primitive types in config_parser
8328617 use if let instead of match
3803543 remove cargo_parser_derive dependency from binary crate

📊 Changes

31 files changed (+1727 additions, -138 deletions)

View changed files

📝 Cargo.lock (+72 -54)
📝 Cargo.toml (+2 -32)
📝 README.md (+6 -13)
➕ config_parser/Cargo.toml (+10 -0)
➕ config_parser/src/lib.rs (+37 -0)
➕ config_parser/tests/test.rs (+107 -0)
➕ config_parser_derive/Cargo.lock (+76 -0)
➕ config_parser_derive/Cargo.toml (+13 -0)
➕ config_parser_derive/src/lib.rs (+13 -0)
➕ config_parser_derive/src/parser.rs (+44 -0)
➕ hackernews_tui/Cargo.lock (+1264 -0)
➕ hackernews_tui/Cargo.toml (+35 -0)
📝 hackernews_tui/src/config.rs (+20 -20)
📝 hackernews_tui/src/hn-tui-default.toml (+8 -9)
📝 hackernews_tui/src/hn_client.rs (+4 -1)
📝 hackernews_tui/src/keybindings.rs (+11 -6)
📝 hackernews_tui/src/main.rs (+0 -0)
📝 hackernews_tui/src/prelude.rs (+0 -0)
📝 hackernews_tui/src/utils.rs (+0 -0)
📝 hackernews_tui/src/view/article_view.rs (+0 -0)

...and 11 more files

📄 Description

Brief description of changes

move the original binary crate to hackernews_tui folder and use [workspaces] option in Cargo.toml
add config_parser and config_parser_derive crates for config parsing

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/39 **Author:** [@aome510](https://github.com/aome510) **Created:** 6/9/2021 **Status:** ✅ Merged **Merged:** 6/12/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `add-config-parser` --- ### 📝 Commits (10+) - [`216b4c2`](https://github.com/aome510/hackernews-TUI/commit/216b4c2e36d3e72e6f31d7357f317a6136ef6b46) move lazy_loading_comments to client config option - [`a0220ef`](https://github.com/aome510/hackernews-TUI/commit/a0220ef36db30b45f3ac6ff50d07f376c5e1e889) move binary package to hackernews_tui folder - [`0206fd7`](https://github.com/aome510/hackernews-TUI/commit/0206fd704ea61d0283d68906640a14d9d07f41a1) implement proc_macro for config_parser in config_parser_derive lib crate - [`55a407b`](https://github.com/aome510/hackernews-TUI/commit/55a407bb8f320a73914580f7efb912f8d858523f) implement config_parser - [`4f3d496`](https://github.com/aome510/hackernews-TUI/commit/4f3d49666c1757c505b41f9f301efbcca3566bb9) use workspaces with multiple crates instead of single binary crate - [`cc2f46c`](https://github.com/aome510/hackernews-TUI/commit/cc2f46c7d01829d6ecbd3b5ef8c9dcfbe7b77656) integrate ConfigParser trait and macros into the binary crate - [`21d0f3d`](https://github.com/aome510/hackernews-TUI/commit/21d0f3d1a6f59c143decf7c4dd59727cf6aa728a) use config_parser when reading from a config file - [`4f39dc6`](https://github.com/aome510/hackernews-TUI/commit/4f39dc666f5734b6691b8097424d5f0516fec364) add more primitive types in config_parser - [`8328617`](https://github.com/aome510/hackernews-TUI/commit/8328617bd3191608ece1eac469af0132b673f13f) use if let instead of match - [`3803543`](https://github.com/aome510/hackernews-TUI/commit/38035430070c1885f0392f8356f71922639d75e4) remove cargo_parser_derive dependency from binary crate ### 📊 Changes **31 files changed** (+1727 additions, -138 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+72 -54) 📝 `Cargo.toml` (+2 -32) 📝 `README.md` (+6 -13) ➕ `config_parser/Cargo.toml` (+10 -0) ➕ `config_parser/src/lib.rs` (+37 -0) ➕ `config_parser/tests/test.rs` (+107 -0) ➕ `config_parser_derive/Cargo.lock` (+76 -0) ➕ `config_parser_derive/Cargo.toml` (+13 -0) ➕ `config_parser_derive/src/lib.rs` (+13 -0) ➕ `config_parser_derive/src/parser.rs` (+44 -0) ➕ `hackernews_tui/Cargo.lock` (+1264 -0) ➕ `hackernews_tui/Cargo.toml` (+35 -0) 📝 `hackernews_tui/src/config.rs` (+20 -20) 📝 `hackernews_tui/src/hn-tui-default.toml` (+8 -9) 📝 `hackernews_tui/src/hn_client.rs` (+4 -1) 📝 `hackernews_tui/src/keybindings.rs` (+11 -6) 📝 `hackernews_tui/src/main.rs` (+0 -0) 📝 `hackernews_tui/src/prelude.rs` (+0 -0) 📝 `hackernews_tui/src/utils.rs` (+0 -0) 📝 `hackernews_tui/src/view/article_view.rs` (+0 -0) _...and 11 more files_ </details> ### 📄 Description **Brief description of changes** - move the original binary crate to `hackernews_tui` folder and use `[workspaces]` option in `Cargo.toml` - add `config_parser` and `config_parser_derive` crates for config parsing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>