[PR #37] [MERGED] Integrate official HackerNews Official APIs P2: implement lazy comments loading #61

New issue

Closed

opened 2026-03-14 12:30:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:30:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/37
Author: @aome510
Created: 6/5/2021
Status: ✅ Merged
Merged: 6/5/2021
Merged by: @aome510

Base: main ← Head: integrate-official-HN-APIs-p2

📝 Commits (10+)

436e684 code refactor in search_view.rs
eb7bc50 WIP
8fcb252 scrolling + comment lazy loading kinda work!
45b09a7 add config option for lazy_loading_comments
f242952 remove story_pooling feature
aa10c42 add back comment reloading
8161dce refine the documentation
831b00a fix some comments
98bd23f update README
ecfb585 refine the documentation

📊 Changes

9 files changed (+252 additions, -153 deletions)

View changed files

📝 README.md (+4 -1)
📝 src/config.rs (+16 -11)
📝 src/hn-tui-default.toml (+6 -13)
📝 src/hn_client.rs (+115 -56)
📝 src/view/async_view.rs (+5 -5)
📝 src/view/comment_view.rs (+86 -29)
📝 src/view/list_view.rs (+7 -0)
📝 src/view/search_view.rs (+12 -9)
📝 src/view/story_view.rs (+1 -29)

📄 Description

implement comment lazy loading using HN Official APIs
a bit of refactoring
remove Story Pooling feature

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/37 **Author:** [@aome510](https://github.com/aome510) **Created:** 6/5/2021 **Status:** ✅ Merged **Merged:** 6/5/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `integrate-official-HN-APIs-p2` --- ### 📝 Commits (10+) - [`436e684`](https://github.com/aome510/hackernews-TUI/commit/436e68476655627eccd7b1e332521d8c7f796287) code refactor in search_view.rs - [`eb7bc50`](https://github.com/aome510/hackernews-TUI/commit/eb7bc509bebbe0d2ad29490533cf28cea5f2a250) WIP - [`8fcb252`](https://github.com/aome510/hackernews-TUI/commit/8fcb2525b6a146dd7d28c596670c9c475d4996a9) scrolling + comment lazy loading kinda work! - [`45b09a7`](https://github.com/aome510/hackernews-TUI/commit/45b09a7daa13442f7c92bf943e90813a1d652edb) add config option for lazy_loading_comments - [`f242952`](https://github.com/aome510/hackernews-TUI/commit/f2429529f60ebfe7bcedb97f9c5d6a9cafd7ce09) remove story_pooling feature - [`aa10c42`](https://github.com/aome510/hackernews-TUI/commit/aa10c423fe49986983a1d91c7211bfd428ff6610) add back comment reloading - [`8161dce`](https://github.com/aome510/hackernews-TUI/commit/8161dcef81c80abd062fecbd95cdf00fd43cb517) refine the documentation - [`831b00a`](https://github.com/aome510/hackernews-TUI/commit/831b00ad51c1149399b7d85e0cdbd623f8e1d1e6) fix some comments - [`98bd23f`](https://github.com/aome510/hackernews-TUI/commit/98bd23f9666270ba7d7b146935f4861a67927c9d) update README - [`ecfb585`](https://github.com/aome510/hackernews-TUI/commit/ecfb585b145d207db07d9511857359e407deb06d) refine the documentation ### 📊 Changes **9 files changed** (+252 additions, -153 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -1) 📝 `src/config.rs` (+16 -11) 📝 `src/hn-tui-default.toml` (+6 -13) 📝 `src/hn_client.rs` (+115 -56) 📝 `src/view/async_view.rs` (+5 -5) 📝 `src/view/comment_view.rs` (+86 -29) 📝 `src/view/list_view.rs` (+7 -0) 📝 `src/view/search_view.rs` (+12 -9) 📝 `src/view/story_view.rs` (+1 -29) </details> ### 📄 Description - implement comment lazy loading using HN Official APIs - a bit of refactoring - remove Story Pooling feature --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>