[PR #34] [MERGED] [no-issue] add custom story view navigation #58

New issue

Closed

opened 2026-03-14 12:29:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:29:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/34
Author: @aome510
Created: 5/17/2021
Status: ✅ Merged
Merged: 5/19/2021
Merged by: @aome510

Base: main ← Head: no-issue-add-custom-view-navigation

📝 Commits (10+)

0b52390 add CustomKeyMap
9573b5e add from_day_offset_to_time_offset_in_secs
dc5a81e move src/view/utils to src/utils.rs
15e311d remove filter past days key shortcuts
a896c83 use hn_client::StoryNumericFilters
f144f64 implement query for numericFilters
e41ceeb add derive Debug to most of the struct with derive macro
9680fea add default for custom_keymap and add more documentation for custom_keymap in the default config file
10e9566 add story filters description for StoryView status bar
50560eb implement key_groups for help_view

📊 Changes

16 files changed (+425 additions, -248 deletions)

View changed files

📝 README.md (+5 -4)
📝 src/config.rs (+10 -6)
📝 src/hn-tui-default.toml (+37 -4)
📝 src/hn_client.rs (+97 -14)
📝 src/keybindings.rs (+33 -15)
📝 src/main.rs (+76 -7)
📝 src/prelude.rs (+1 -0)
📝 src/utils.rs (+9 -16)
📝 src/view/article_view.rs (+1 -2)
📝 src/view/async_view.rs (+5 -6)
📝 src/view/comment_view.rs (+0 -1)
📝 src/view/error_view.rs (+0 -1)
📝 src/view/help_view.rs (+145 -113)
📝 src/view/mod.rs (+0 -1)
📝 src/view/search_view.rs (+0 -1)
📝 src/view/story_view.rs (+6 -57)

📄 Description

Changes

remove q,w,e,r for filter stories by date.
add user-defined command for custom StoryView navigation
add Derive(Debug) for most of the structs
move view/utils.rs to utils.rs
change function handlers in HelpView to support displaying description for custom keymap.
function/variable naming changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/34 **Author:** [@aome510](https://github.com/aome510) **Created:** 5/17/2021 **Status:** ✅ Merged **Merged:** 5/19/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `no-issue-add-custom-view-navigation` --- ### 📝 Commits (10+) - [`0b52390`](https://github.com/aome510/hackernews-TUI/commit/0b523907b267b48a186957c5e42f6b9928aa82ac) add CustomKeyMap - [`9573b5e`](https://github.com/aome510/hackernews-TUI/commit/9573b5e47adf5aabd1c3be06d1d059cf12d584f1) add from_day_offset_to_time_offset_in_secs - [`dc5a81e`](https://github.com/aome510/hackernews-TUI/commit/dc5a81e69464d363efe9c72676869623726646f6) move src/view/utils to src/utils.rs - [`15e311d`](https://github.com/aome510/hackernews-TUI/commit/15e311d43d2401e66da19eabb554154b5eb4f092) remove filter past days key shortcuts - [`a896c83`](https://github.com/aome510/hackernews-TUI/commit/a896c8303250a70fdacf4553e0852efc863138a2) use hn_client::StoryNumericFilters - [`f144f64`](https://github.com/aome510/hackernews-TUI/commit/f144f6490c1c3a45a74bac428823d08b9954836b) implement query for numericFilters - [`e41ceeb`](https://github.com/aome510/hackernews-TUI/commit/e41ceeb6a336a048093bcf7c4548d966abbff56e) add derive Debug to most of the struct with derive macro - [`9680fea`](https://github.com/aome510/hackernews-TUI/commit/9680fea0a63e9f9ac6f8d6f7f04617bbf2e6e4d7) add default for custom_keymap and add more documentation for custom_keymap in the default config file - [`10e9566`](https://github.com/aome510/hackernews-TUI/commit/10e9566f3ce674a89737b887c1fa232485afa3cc) add story filters description for StoryView status bar - [`50560eb`](https://github.com/aome510/hackernews-TUI/commit/50560ebaae4d4eda7b930e0507da5a0ce82c5b94) implement key_groups for help_view ### 📊 Changes **16 files changed** (+425 additions, -248 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+5 -4) 📝 `src/config.rs` (+10 -6) 📝 `src/hn-tui-default.toml` (+37 -4) 📝 `src/hn_client.rs` (+97 -14) 📝 `src/keybindings.rs` (+33 -15) 📝 `src/main.rs` (+76 -7) 📝 `src/prelude.rs` (+1 -0) 📝 `src/utils.rs` (+9 -16) 📝 `src/view/article_view.rs` (+1 -2) 📝 `src/view/async_view.rs` (+5 -6) 📝 `src/view/comment_view.rs` (+0 -1) 📝 `src/view/error_view.rs` (+0 -1) 📝 `src/view/help_view.rs` (+145 -113) 📝 `src/view/mod.rs` (+0 -1) 📝 `src/view/search_view.rs` (+0 -1) 📝 `src/view/story_view.rs` (+6 -57) </details> ### 📄 Description **Changes** - remove `q,w,e,r` for filter stories by date. - add user-defined command for custom `StoryView` navigation - add `Derive(Debug)` for most of the structs - move `view/utils.rs` to `utils.rs` - change function handlers in `HelpView` to support displaying description for custom keymap. - function/variable naming changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>