[PR #33] [MERGED] [no-issue] implement article view #57

New issue

Closed

opened 2026-03-14 12:29:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:29:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/33
Author: @aome510
Created: 4/28/2021
Status: ✅ Merged
Merged: 4/29/2021
Merged by: @aome510

Base: main ← Head: implement-article-view

📝 Commits (10+)

1626d31 add article_view
c9eecf0 add serde_json
8f26169 add error handling in get_article_view_async
45aae3e add Article struct
231b9da add keybindings to open artcile/url in article_view
3ef4f48 add add_comment_view_layer
baebf92 wrap article_view with status_bar, footer
2c9597f add j,k,d,u for article_view
583e14d add regexs to parse links/images from markdown raw text
acf9555 update url regex to greedy matching

📊 Changes

16 files changed (+693 additions, -50 deletions)

View changed files

📝 Cargo.lock (+2 -0)
📝 Cargo.toml (+2 -0)
📝 README.md (+28 -4)
📝 src/config.rs (+4 -0)
📝 src/hn-tui-default.toml (+16 -0)
📝 src/keybindings.rs (+45 -0)
📝 src/prelude.rs (+1 -0)
➕ src/view/article_view.rs (+361 -0)
📝 src/view/async_view.rs (+45 -4)
📝 src/view/comment_view.rs (+61 -22)
📝 src/view/error_view.rs (+2 -2)
📝 src/view/help_view.rs (+98 -7)
📝 src/view/list_view.rs (+4 -2)
📝 src/view/mod.rs (+1 -0)
📝 src/view/search_view.rs (+7 -4)
📝 src/view/story_view.rs (+16 -5)

📄 Description

Add ArticleView to read articles in reader mode directly in the application with the help of mercury-parser

Brief description of changes

add ArticleView and its shortcuts
add shortcuts for open links in ArticleView
update README
add serde_json package to parse json bytes to Article struct
add url package

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/33 **Author:** [@aome510](https://github.com/aome510) **Created:** 4/28/2021 **Status:** ✅ Merged **Merged:** 4/29/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `implement-article-view` --- ### 📝 Commits (10+) - [`1626d31`](https://github.com/aome510/hackernews-TUI/commit/1626d318a6e81bd3af7666ab68945ad74d6552d8) add article_view - [`c9eecf0`](https://github.com/aome510/hackernews-TUI/commit/c9eecf01adccc181d41648bb1a9b470d171a213c) add serde_json - [`8f26169`](https://github.com/aome510/hackernews-TUI/commit/8f26169616d94e03db91a4de46a3d2858598592a) add error handling in get_article_view_async - [`45aae3e`](https://github.com/aome510/hackernews-TUI/commit/45aae3eec471012758f5d425a867670d2ea3f23a) add Article struct - [`231b9da`](https://github.com/aome510/hackernews-TUI/commit/231b9da50c1ed7a7ab44857e41e943a540373e99) add keybindings to open artcile/url in article_view - [`3ef4f48`](https://github.com/aome510/hackernews-TUI/commit/3ef4f4819e21a1d5da5be3843055bdfa132eb876) add add_comment_view_layer - [`baebf92`](https://github.com/aome510/hackernews-TUI/commit/baebf927400321ecc7699bb411436bc5c61665be) wrap article_view with status_bar, footer - [`2c9597f`](https://github.com/aome510/hackernews-TUI/commit/2c9597f00383444579ec00cd38a7875f65a45eac) add j,k,d,u for article_view - [`583e14d`](https://github.com/aome510/hackernews-TUI/commit/583e14d7d20a9595ff5403da81342756328bef40) add regexs to parse links/images from markdown raw text - [`acf9555`](https://github.com/aome510/hackernews-TUI/commit/acf9555735bb40d234f4826da2e3b03f24395986) update url regex to greedy matching ### 📊 Changes **16 files changed** (+693 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -0) 📝 `Cargo.toml` (+2 -0) 📝 `README.md` (+28 -4) 📝 `src/config.rs` (+4 -0) 📝 `src/hn-tui-default.toml` (+16 -0) 📝 `src/keybindings.rs` (+45 -0) 📝 `src/prelude.rs` (+1 -0) ➕ `src/view/article_view.rs` (+361 -0) 📝 `src/view/async_view.rs` (+45 -4) 📝 `src/view/comment_view.rs` (+61 -22) 📝 `src/view/error_view.rs` (+2 -2) 📝 `src/view/help_view.rs` (+98 -7) 📝 `src/view/list_view.rs` (+4 -2) 📝 `src/view/mod.rs` (+1 -0) 📝 `src/view/search_view.rs` (+7 -4) 📝 `src/view/story_view.rs` (+16 -5) </details> ### 📄 Description Add `ArticleView` to read articles in reader mode directly in the application with the help of [mercury-parser](https://github.com/postlight/mercury-parser) **Brief description of changes** - add `ArticleView` and its shortcuts - add shortcuts for open links in `ArticleView` - update `README` - add `serde_json` package to parse json bytes to `Article` struct - add `url` package --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>