[PR #26] [MERGED] [no-issue] Add time_offset filtering for StoryView and paging for SearchView #52

Closed
opened 2026-03-14 12:29:36 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/26
Author: @aome510
Created: 4/23/2021
Status: Merged
Merged: 4/23/2021
Merged by: @aome510

Base: mainHead: add-date-filter


📝 Commits (10+)

  • 29ccb59 use sort_by: (date|popular) desc
  • 99c657a increase client default timeout to 1min
  • 2eb7cbd improve update_view switch_mode logic
  • e8376e1 implement time_offset filtering in hn_client
  • 692371c add time_offset option when creating new StoryView
  • d16ca93 add time_offset desc in StoryView title
  • 6a68da5 add aligned_view for cursive_async_view
  • decafb8 minor edit
  • 9dcf315 add pop layer with ctrl/alt-p
  • 2111923 add new shortcuts to help_view

📊 Changes

9 files changed (+341 additions, -108 deletions)

View changed files

📝 Cargo.lock (+10 -0)
📝 Cargo.toml (+4 -2)
📝 src/hn_client.rs (+29 -6)
📝 src/main.rs (+18 -6)
📝 src/view/async_view.rs (+10 -3)
📝 src/view/help_view.rs (+60 -21)
📝 src/view/search_view.rs (+112 -40)
📝 src/view/story_view.rs (+69 -17)
📝 src/view/utils.rs (+29 -13)

📄 Description

  • implement time_offset filter option
  • allow Views to be stacked
  • implement sort_by, and paging for StoryView
  • modify documentation and key bindings to adjust new changes
  • change View title description
  • use cursive_aligned_view along with cursive_async_view for loading screen

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/26 **Author:** [@aome510](https://github.com/aome510) **Created:** 4/23/2021 **Status:** ✅ Merged **Merged:** 4/23/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `add-date-filter` --- ### 📝 Commits (10+) - [`29ccb59`](https://github.com/aome510/hackernews-TUI/commit/29ccb5937198c30e47259f590ff7f1a1f9f6cbd7) use sort_by: (date|popular) desc - [`99c657a`](https://github.com/aome510/hackernews-TUI/commit/99c657a921348807912ec6ddea4e46993dd8e80a) increase client default timeout to 1min - [`2eb7cbd`](https://github.com/aome510/hackernews-TUI/commit/2eb7cbde7b917f0685468fb52a839cf01c6cb5a0) improve update_view switch_mode logic - [`e8376e1`](https://github.com/aome510/hackernews-TUI/commit/e8376e1faf3c35c9f400642dee460b090c330956) implement time_offset filtering in hn_client - [`692371c`](https://github.com/aome510/hackernews-TUI/commit/692371c735bdaf41798c0ecb61ef0ab548066ded) add time_offset option when creating new StoryView - [`d16ca93`](https://github.com/aome510/hackernews-TUI/commit/d16ca9373e063d20aaca1279bf57cf73a926a49d) add time_offset desc in StoryView title - [`6a68da5`](https://github.com/aome510/hackernews-TUI/commit/6a68da5da81ea52b9b1cd803bfe35497429666fd) add aligned_view for cursive_async_view - [`decafb8`](https://github.com/aome510/hackernews-TUI/commit/decafb8155af78397cb2d78187dd74d5156202c5) minor edit - [`9dcf315`](https://github.com/aome510/hackernews-TUI/commit/9dcf315d018db8172448d129b987cb68c998d70f) add pop layer with ctrl/alt-p - [`2111923`](https://github.com/aome510/hackernews-TUI/commit/21119237aed076f78f9f20aad68af922efa07fcc) add new shortcuts to help_view ### 📊 Changes **9 files changed** (+341 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+10 -0) 📝 `Cargo.toml` (+4 -2) 📝 `src/hn_client.rs` (+29 -6) 📝 `src/main.rs` (+18 -6) 📝 `src/view/async_view.rs` (+10 -3) 📝 `src/view/help_view.rs` (+60 -21) 📝 `src/view/search_view.rs` (+112 -40) 📝 `src/view/story_view.rs` (+69 -17) 📝 `src/view/utils.rs` (+29 -13) </details> ### 📄 Description - implement `time_offset` filter option - allow `View`s to be stacked - implement `sort_by`, and paging for `StoryView` - modify documentation and key bindings to adjust new changes - change `View` title description - use `cursive_aligned_view` along with `cursive_async_view` for loading screen --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 12:29:36 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hackernews-TUI#52
No description provided.