[PR #19] [MERGED] [no-issue] Implement story cache #45

Closed
opened 2026-03-14 12:29:19 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/19
Author: @aome510
Created: 3/30/2021
Status: Merged
Merged: 3/30/2021
Merged by: @aome510

Base: mainHead: implement-story-cache


📝 Commits (4)

  • 4c65cf5 add story_caches
  • e063d3e consider reloading when using r in comment_view
  • 5c172eb add story pooling in background
  • 161a45b better documentation

📊 Changes

4 files changed (+145 additions, -80 deletions)

View changed files

📝 src/hn_client.rs (+105 -29)
📝 src/view/async_view.rs (+8 -9)
📝 src/view/comment_view.rs (+14 -35)
📝 src/view/story_view.rs (+18 -7)

📄 Description

  • implement story_caches in hn_client::Client storing caches of story's comments.
  • add story pooling in background.
  • remove comment_view::Story to use hn_client::Story instead to represent story's metdata.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/19 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/30/2021 **Status:** ✅ Merged **Merged:** 3/30/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `implement-story-cache` --- ### 📝 Commits (4) - [`4c65cf5`](https://github.com/aome510/hackernews-TUI/commit/4c65cf5e760d6f679d79426da3fbc580f94593bc) add story_caches - [`e063d3e`](https://github.com/aome510/hackernews-TUI/commit/e063d3e7ae6409a13784694551b779cd7504b741) consider reloading when using r in comment_view - [`5c172eb`](https://github.com/aome510/hackernews-TUI/commit/5c172ebe73a86040c416acbe26daf5d2e67c6445) add story pooling in background - [`161a45b`](https://github.com/aome510/hackernews-TUI/commit/161a45ba5c0156d63cae13d9777f01b80fe049f3) better documentation ### 📊 Changes **4 files changed** (+145 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `src/hn_client.rs` (+105 -29) 📝 `src/view/async_view.rs` (+8 -9) 📝 `src/view/comment_view.rs` (+14 -35) 📝 `src/view/story_view.rs` (+18 -7) </details> ### 📄 Description - implement `story_caches` in `hn_client::Client` storing caches of story's comments. - add story pooling in background. - remove `comment_view::Story` to use `hn_client::Story` instead to represent story's metdata. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 12:29:19 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hackernews-TUI#45
No description provided.