[PR #14] [MERGED] [#9] add search view #41

New issue

Closed

opened 2026-03-14 12:29:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:29:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/14
Author: @aome510
Created: 3/13/2021
Status: ✅ Merged
Merged: 3/13/2021
Merged by: @aome510

Base: main ← Head: 9-more-story-view

📝 Commits (10+)

433fc40 change rewquest to ureq
1af7d85 categorize keys based on their functionalities
395c7cf move {StoryView,CommentView}::construct_help_view into help_view module
c7f445e change wordings in the help dialog
fed64f2 update key shortcuts section in README
2b9edec add simple search view, change some key shortcuts to alt {key}
a95294b add searchResult structs into Story struct
ddc0787 improve search view with story view + navigation shortcuts
aa75594 search view with editable query_text_view kind of works
39f7880 work but slow search_view

📊 Changes

15 files changed (+665 additions, -770 deletions)

View changed files

📝 Cargo.lock (+82 -564)
📝 Cargo.toml (+1 -1)
📝 README.md (+4 -18)
📝 src/hn_client.rs (+46 -8)
📝 src/main.rs (+1 -1)
📝 src/view/comment_view.rs (+27 -15)
📝 src/view/error_view.rs (+7 -39)
📝 src/view/event_view.rs (+1 -67)
➕ src/view/fn_view_wrapper.rs (+53 -0)
📝 src/view/help_view.rs (+159 -24)
📝 src/view/mod.rs (+2 -0)
➕ src/view/search_view.rs (+220 -0)
📝 src/view/story_view.rs (+46 -32)
📝 src/view/theme.rs (+2 -0)
📝 src/view/utils.rs (+14 -1)

📄 Description

Part of #9.

add SearchView
refactor codes in some places
use ureq instead of rewquest for the http client
improve HelpView dialog

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/14 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/13/2021 **Status:** ✅ Merged **Merged:** 3/13/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `9-more-story-view` --- ### 📝 Commits (10+) - [`433fc40`](https://github.com/aome510/hackernews-TUI/commit/433fc400ab07728aa3a214931edff71836de6eee) change rewquest to ureq - [`1af7d85`](https://github.com/aome510/hackernews-TUI/commit/1af7d8581aebf74fdb96da7bd66370aa1e663252) categorize keys based on their functionalities - [`395c7cf`](https://github.com/aome510/hackernews-TUI/commit/395c7cf4da615baa93bab0aa7cc45b2c80596d73) move {StoryView,CommentView}::construct_help_view into help_view module - [`c7f445e`](https://github.com/aome510/hackernews-TUI/commit/c7f445eb08a816bae297ae7da394a2b15116192b) change wordings in the help dialog - [`fed64f2`](https://github.com/aome510/hackernews-TUI/commit/fed64f208ae5c8bf53b1a4a32371b9231505b16e) update key shortcuts section in README - [`2b9edec`](https://github.com/aome510/hackernews-TUI/commit/2b9edec2b543623b29ca762f5962f3e32ebac0b5) add simple search view, change some key shortcuts to alt {key} - [`a95294b`](https://github.com/aome510/hackernews-TUI/commit/a95294bf0d921dfb7b88fa42044042697a9703b7) add searchResult structs into Story struct - [`ddc0787`](https://github.com/aome510/hackernews-TUI/commit/ddc0787123a32710d3a3b70cad168b2c0bce47cc) improve search view with story view + navigation shortcuts - [`aa75594`](https://github.com/aome510/hackernews-TUI/commit/aa75594eb94601bdb0574116bcb1fc15f41d82fc) search view with editable query_text_view kind of works - [`39f7880`](https://github.com/aome510/hackernews-TUI/commit/39f78805d7791dfd6dfcedbae66b016405e50a1d) work but slow search_view ### 📊 Changes **15 files changed** (+665 additions, -770 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+82 -564) 📝 `Cargo.toml` (+1 -1) 📝 `README.md` (+4 -18) 📝 `src/hn_client.rs` (+46 -8) 📝 `src/main.rs` (+1 -1) 📝 `src/view/comment_view.rs` (+27 -15) 📝 `src/view/error_view.rs` (+7 -39) 📝 `src/view/event_view.rs` (+1 -67) ➕ `src/view/fn_view_wrapper.rs` (+53 -0) 📝 `src/view/help_view.rs` (+159 -24) 📝 `src/view/mod.rs` (+2 -0) ➕ `src/view/search_view.rs` (+220 -0) 📝 `src/view/story_view.rs` (+46 -32) 📝 `src/view/theme.rs` (+2 -0) 📝 `src/view/utils.rs` (+14 -1) </details> ### 📄 Description Part of #9. - add `SearchView` - refactor codes in some places - use `ureq` instead of `rewquest` for the http client - improve `HelpView` dialog --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>