[PR #12] [MERGED] [#11] add loading screen and error view #36

New issue

Closed

opened 2026-03-14 12:28:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:28:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/12
Author: @aome510
Created: 3/6/2021
Status: ✅ Merged
Merged: 3/6/2021
Merged by: @aome510

Base: main ← Head: 11-add-loading-screen

📝 Commits (6)

486e7a5 add cursive_async_view
56b57cd add async_view, error_view
ab27e49 add ErrorView
9be5c6f add debugs
3241e78 add simple error view
6104961 remove start from main

📊 Changes

10 files changed (+288 additions, -70 deletions)

View changed files

📝 Cargo.lock (+86 -14)
📝 Cargo.toml (+1 -0)
📝 src/hn_client.rs (+14 -2)
📝 src/main.rs (+3 -10)
📝 src/prelude.rs (+4 -3)
➕ src/view/async_view.rs (+60 -0)
📝 src/view/comment_view.rs (+9 -13)
➕ src/view/error_view.rs (+99 -0)
📝 src/view/mod.rs (+2 -0)
📝 src/view/story_view.rs (+10 -28)

📄 Description

Resolve #11.

add a simple loading screen using cursive-async-view.
add error_view module to display error to user.
wrap get_story_view and get_comment_view into associated async functions that returned the corresponded View with a loading screen.
rename hn_client to client for consistency.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/12 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/6/2021 **Status:** ✅ Merged **Merged:** 3/6/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `11-add-loading-screen` --- ### 📝 Commits (6) - [`486e7a5`](https://github.com/aome510/hackernews-TUI/commit/486e7a5f072f6faa5f58ac4abc349b372e1f7ad5) add cursive_async_view - [`56b57cd`](https://github.com/aome510/hackernews-TUI/commit/56b57cd59b0ec28cc30f1b8e48d80cfcc530a59c) add async_view, error_view - [`ab27e49`](https://github.com/aome510/hackernews-TUI/commit/ab27e49cdd6d681ce9e5bd790a1b96c5b04993bb) add ErrorView - [`9be5c6f`](https://github.com/aome510/hackernews-TUI/commit/9be5c6f41593fedf6acc2f6722017743a60642f9) add debugs - [`3241e78`](https://github.com/aome510/hackernews-TUI/commit/3241e78da5b8bb36ebac6644b5c491f01361e567) add simple error view - [`6104961`](https://github.com/aome510/hackernews-TUI/commit/610496183d8b6e718685ac8bece43a546f45117a) remove start from main ### 📊 Changes **10 files changed** (+288 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+86 -14) 📝 `Cargo.toml` (+1 -0) 📝 `src/hn_client.rs` (+14 -2) 📝 `src/main.rs` (+3 -10) 📝 `src/prelude.rs` (+4 -3) ➕ `src/view/async_view.rs` (+60 -0) 📝 `src/view/comment_view.rs` (+9 -13) ➕ `src/view/error_view.rs` (+99 -0) 📝 `src/view/mod.rs` (+2 -0) 📝 `src/view/story_view.rs` (+10 -28) </details> ### 📄 Description Resolve #11. - add a simple loading screen using `cursive-async-view`. - add `error_view` module to display error to user. - wrap `get_story_view` and `get_comment_view` into associated async functions that returned the corresponded `View` with a loading screen. - rename `hn_client` to `client` for consistency. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>