[PR #99] [MERGED] Update Hacker News HTML text parsing logic #106

Closed
opened 2026-03-14 12:32:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/hackernews-TUI/pull/99
Author: @aome510
Created: 10/21/2023
Status: Merged
Merged: 10/21/2023
Merged by: @aome510

Base: mainHead: update-hn-text-parse-logic


📝 Commits (2)

  • 944cf78 rename HTMLParsedResult to HTMLTextParsedResult
  • d451fa3 update hn html text parsing logic

📊 Changes

5 files changed (+97 additions, -83 deletions)

View changed files

📝 hackernews_tui/src/client/mod.rs (+1 -3)
📝 hackernews_tui/src/model.rs (+15 -13)
📝 hackernews_tui/src/parser/article.rs (+21 -17)
📝 hackernews_tui/src/parser/html.rs (+59 -49)
📝 hackernews_tui/src/view/article_view.rs (+1 -1)

📄 Description

Changes

  • update parsing logic to reflect new HN Algolia API change regarding the use of <p> for paragraph breaks
  • cleanup parsing codes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/hackernews-TUI/pull/99 **Author:** [@aome510](https://github.com/aome510) **Created:** 10/21/2023 **Status:** ✅ Merged **Merged:** 10/21/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `main` ← **Head:** `update-hn-text-parse-logic` --- ### 📝 Commits (2) - [`944cf78`](https://github.com/aome510/hackernews-TUI/commit/944cf78db81e415a174c99da23e68e462419c5e6) rename `HTMLParsedResult` to `HTMLTextParsedResult` - [`d451fa3`](https://github.com/aome510/hackernews-TUI/commit/d451fa3d7e637e36f36b524abb472e5de5ba4f92) update hn html text parsing logic ### 📊 Changes **5 files changed** (+97 additions, -83 deletions) <details> <summary>View changed files</summary> 📝 `hackernews_tui/src/client/mod.rs` (+1 -3) 📝 `hackernews_tui/src/model.rs` (+15 -13) 📝 `hackernews_tui/src/parser/article.rs` (+21 -17) 📝 `hackernews_tui/src/parser/html.rs` (+59 -49) 📝 `hackernews_tui/src/view/article_view.rs` (+1 -1) </details> ### 📄 Description ## Changes - update parsing logic to reflect new HN Algolia API change regarding the use of `<p>` for paragraph breaks - cleanup parsing codes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 12:32:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hackernews-TUI#106
No description provided.