[PR #91] Fix issues related to creating custom adapters in other projects, #88 #89 #95

Open
opened 2026-03-03 00:03:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/atulmy/gql-query-builder/pull/91
Author: @yargyropoulos
Created: 12/18/2023
Status: 🔄 Open

Base: masterHead: fix-ext-issues-88-89


📝 Commits (2)

  • 21b6e95 allow any type for mutation and subscription adapters
  • ad693ea export Utils functions separately instead of exporting a class with static methods

📊 Changes

7 files changed (+187 additions, -183 deletions)

View changed files

📝 src/Utils.ts (+142 -150)
📝 src/adapters/DefaultAppSyncMutationAdapter.ts (+5 -5)
📝 src/adapters/DefaultAppSyncQueryAdapter.ts (+4 -4)
📝 src/adapters/DefaultMutationAdapter.ts (+15 -10)
📝 src/adapters/DefaultQueryAdapter.ts (+14 -7)
📝 src/adapters/DefaultSubscriptionAdapter.ts (+5 -5)
📝 src/index.ts (+2 -2)

📄 Description

This is my suggested fix for 2 issues I've raised recently :

With these 2 changes I was able to write my own custom Query and Mutation Adapters.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/atulmy/gql-query-builder/pull/91 **Author:** [@yargyropoulos](https://github.com/yargyropoulos) **Created:** 12/18/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix-ext-issues-88-89` --- ### 📝 Commits (2) - [`21b6e95`](https://github.com/atulmy/gql-query-builder/commit/21b6e952580574dda89881930a7db909448bdc56) allow any type for mutation and subscription adapters - [`ad693ea`](https://github.com/atulmy/gql-query-builder/commit/ad693eaaa4d5105312d01cd2ca9444be1aea8184) export Utils functions separately instead of exporting a class with static methods ### 📊 Changes **7 files changed** (+187 additions, -183 deletions) <details> <summary>View changed files</summary> 📝 `src/Utils.ts` (+142 -150) 📝 `src/adapters/DefaultAppSyncMutationAdapter.ts` (+5 -5) 📝 `src/adapters/DefaultAppSyncQueryAdapter.ts` (+4 -4) 📝 `src/adapters/DefaultMutationAdapter.ts` (+15 -10) 📝 `src/adapters/DefaultQueryAdapter.ts` (+14 -7) 📝 `src/adapters/DefaultSubscriptionAdapter.ts` (+5 -5) 📝 `src/index.ts` (+2 -2) </details> ### 📄 Description This is my suggested fix for 2 issues I've raised recently : - [Cannot create custom Mutation or Subscription Adapter](https://github.com/atulmy/gql-query-builder/issues/89) - [Cannot use Utils methods in custom Adapter](https://github.com/atulmy/gql-query-builder/issues/88) With these 2 changes I was able to write my own custom Query and Mutation Adapters. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/gql-query-builder#95
No description provided.