[PR #59] [MERGED] Refactor to fix list type definition of VariableOptions #82

New issue

Closed

opened 2026-03-03 00:03:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:03:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/atulmy/gql-query-builder/pull/59
Author: @t2y
Created: 6/21/2021
Status: ✅ Merged
Merged: 1/8/2022
Merged by: @atulmy

Base: master ← Head: fix-list-type-definition

📝 Commits (2)

cf35b43 fix: fixed a trivial typo in README
e97515b refactor: fixed list type definition of VariableOptions

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 README.md (+2 -2)
📝 src/VariableOptions.ts (+1 -1)

📄 Description

According to implementation and #28, the list type definition of VariableOptions is wrong.

src/Utils.ts

      } else if (Array.isArray(variable.list)) {
        type = `[${type}${variable.list[0] ? "!" : ""}]`;
      }

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/atulmy/gql-query-builder/pull/59 **Author:** [@t2y](https://github.com/t2y) **Created:** 6/21/2021 **Status:** ✅ Merged **Merged:** 1/8/2022 **Merged by:** [@atulmy](https://github.com/atulmy) **Base:** `master` ← **Head:** `fix-list-type-definition` --- ### 📝 Commits (2) - [`cf35b43`](https://github.com/atulmy/gql-query-builder/commit/cf35b43a561da4f39c467a57d871dcc4d1b943bc) fix: fixed a trivial typo in README - [`e97515b`](https://github.com/atulmy/gql-query-builder/commit/e97515b71aabdc7030f20970d61c74b297b80ac6) refactor: fixed list type definition of VariableOptions ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -2) 📝 `src/VariableOptions.ts` (+1 -1) </details> ### 📄 Description According to implementation and #28, the `list` type definition of VariableOptions is wrong. * src/Utils.ts ```typescript } else if (Array.isArray(variable.list)) { type = `[${type}${variable.list[0] ? "!" : ""}]`; } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>