[PR #141] [MERGED] remove some commented-out (dead) code #543

Closed
opened 2026-02-27 23:17:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/snail007/goproxy/pull/141
Author: @quasilyte
Created: 9/13/2018
Status: Merged
Merged: 9/14/2018
Merged by: @snail007

Base: devHead: quasilyte/commentedOutCode


📝 Commits (1)

  • 6154d41 remove some commented-out (dead) code

📊 Changes

3 files changed (+0 additions, -4 deletions)

View changed files

📝 core/cs/server/server.go (+0 -1)
📝 services/mux/mux_bridge.go (+0 -1)
📝 services/sps/sps.go (+0 -2)

📄 Description

There are much more places, removed only few of them
to make review simpler (we can remove more later).

Found using https://go-critic.github.io/overview#commentedOutCode-ref


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/snail007/goproxy/pull/141 **Author:** [@quasilyte](https://github.com/quasilyte) **Created:** 9/13/2018 **Status:** ✅ Merged **Merged:** 9/14/2018 **Merged by:** [@snail007](https://github.com/snail007) **Base:** `dev` ← **Head:** `quasilyte/commentedOutCode` --- ### 📝 Commits (1) - [`6154d41`](https://github.com/snail007/goproxy/commit/6154d4173a85b706a13cf49eb922c0fc427b8147) remove some commented-out (dead) code ### 📊 Changes **3 files changed** (+0 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `core/cs/server/server.go` (+0 -1) 📝 `services/mux/mux_bridge.go` (+0 -1) 📝 `services/sps/sps.go` (+0 -2) </details> ### 📄 Description There are much more places, removed only few of them to make review simpler (we can remove more later). Found using https://go-critic.github.io/overview#commentedOutCode-ref --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:17:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/goproxy#543
No description provided.