[PR #140] [MERGED] services: simplify switch statements with case clause lists #539

New issue

Closed

opened 2026-02-27 23:17:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:17:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/snail007/goproxy/pull/140
Author: @quasilyte
Created: 9/13/2018
Status: ✅ Merged
Merged: 9/14/2018
Merged by: @snail007

Base: dev ← Head: quasilyte/emptyFallthrough

📝 Commits (3)

900b975 Update install_auto.sh
70067d6 services: simplify switch statements with case clause lists
03ef384 Update install_auto.sh

📊 Changes

4 files changed (+4 additions, -18 deletions)

View changed files

📝 services/socks/socks.go (+1 -5)
📝 services/sps/sps.go (+1 -5)
📝 services/tcp/tcp.go (+1 -5)
📝 services/udp/udp.go (+1 -3)

📄 Description

Case clause lists are simpler and more compact than
multiple cases with fallthrough.

Found using https://go-critic.github.io/overview#emptyFallthrough-ref

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/snail007/goproxy/pull/140 **Author:** [@quasilyte](https://github.com/quasilyte) **Created:** 9/13/2018 **Status:** ✅ Merged **Merged:** 9/14/2018 **Merged by:** [@snail007](https://github.com/snail007) **Base:** `dev` ← **Head:** `quasilyte/emptyFallthrough` --- ### 📝 Commits (3) - [`900b975`](https://github.com/snail007/goproxy/commit/900b975c6a85cd25c27ac35e21e8bfce231c5152) Update install_auto.sh - [`70067d6`](https://github.com/snail007/goproxy/commit/70067d67b9623e3e345cbfb26eed1d4d4e34dcee) services: simplify switch statements with case clause lists - [`03ef384`](https://github.com/snail007/goproxy/commit/03ef384c480cfc25b94e0e5ca2052911c644f3e4) Update install_auto.sh ### 📊 Changes **4 files changed** (+4 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `services/socks/socks.go` (+1 -5) 📝 `services/sps/sps.go` (+1 -5) 📝 `services/tcp/tcp.go` (+1 -5) 📝 `services/udp/udp.go` (+1 -3) </details> ### 📄 Description Case clause lists are simpler and more compact than multiple cases with fallthrough. Found using https://go-critic.github.io/overview#emptyFallthrough-ref --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>