[PR #218] [MERGED] Add phpstan/phpstan-strict-rules #687

New issue

Closed

opened 2026-03-14 12:20:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:20:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/218
Author: @spaze
Created: 10/13/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @antonioribeiro

Base: 9.x ← Head: spaze/phpstan-strict-rules

📝 Commits (2)

08f3c23 Add phpstan/phpstan-strict-rules
bc49457 Fix strict rules errors

📊 Changes

6 files changed (+104 additions, -100 deletions)

View changed files

📝 composer.json (+2 -1)
📝 phpstan.neon (+1 -0)
📝 src/Google2FA.php (+1 -1)
📝 src/Support/Base32.php (+1 -1)
📝 tests/Google2FATest.php (+97 -96)
📝 tests/QRCodeTest.php (+2 -1)

📄 Description

As discussed in https://github.com/antonioribeiro/google2fa/pull/215#issuecomment-2409109496

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/218 **Author:** [@spaze](https://github.com/spaze) **Created:** 10/13/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `9.x` ← **Head:** `spaze/phpstan-strict-rules` --- ### 📝 Commits (2) - [`08f3c23`](https://github.com/antonioribeiro/google2fa/commit/08f3c230273ab40aad22c7d8776af9341a0f8d70) Add phpstan/phpstan-strict-rules - [`bc49457`](https://github.com/antonioribeiro/google2fa/commit/bc4945797c39c1c057de3137010f36063bd48b32) Fix strict rules errors ### 📊 Changes **6 files changed** (+104 additions, -100 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+2 -1) 📝 `phpstan.neon` (+1 -0) 📝 `src/Google2FA.php` (+1 -1) 📝 `src/Support/Base32.php` (+1 -1) 📝 `tests/Google2FATest.php` (+97 -96) 📝 `tests/QRCodeTest.php` (+2 -1) </details> ### 📄 Description As discussed in https://github.com/antonioribeiro/google2fa/pull/215#issuecomment-2409109496 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-14 12:20:05 +03:00

closed this issue
added the
pull-request
label

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/google2fa#687

No description provided.

Rows
Columns