[PR #188] [MERGED] PHPStan CI #669

New issue

Closed

opened 2026-03-14 12:19:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:19:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/188
Author: @spaze
Created: 2/8/2023
Status: ✅ Merged
Merged: 3/1/2023
Merged by: @antonioribeiro

Base: 8.x ← Head: spaze/phpstan-ci

📝 Commits (3)

dcfe6f2 Change nulls to empty strings & zeros to satisfy type hints (and PHPStan)
52d6f6c Run PHPStan on CI
9fc07fb Run tests on PRs too

📊 Changes

2 files changed (+6 additions, -2 deletions)

View changed files

📝 .github/workflows/run-tests.yml (+4 -0)
📝 tests/Google2FATest.php (+2 -2)

📄 Description

Fix errors reported by PHPStan (nulls instead of strings & ints in a test file)
Run PHPStan in CI
... and on PRs

I'd also recommend protecting the default branch in repo settings and making the tests required before a PR can be merged.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/188 **Author:** [@spaze](https://github.com/spaze) **Created:** 2/8/2023 **Status:** ✅ Merged **Merged:** 3/1/2023 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `8.x` ← **Head:** `spaze/phpstan-ci` --- ### 📝 Commits (3) - [`dcfe6f2`](https://github.com/antonioribeiro/google2fa/commit/dcfe6f20b0d1c0c2628474ceb9fb0a22ae22cddd) Change nulls to empty strings & zeros to satisfy type hints (and PHPStan) - [`52d6f6c`](https://github.com/antonioribeiro/google2fa/commit/52d6f6c02d4c443f3b2786928dc4bfa94ed2efc2) Run PHPStan on CI - [`9fc07fb`](https://github.com/antonioribeiro/google2fa/commit/9fc07fb02486e1781c863b59cc551892353fecc6) Run tests on PRs too ### 📊 Changes **2 files changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/run-tests.yml` (+4 -0) 📝 `tests/Google2FATest.php` (+2 -2) </details> ### 📄 Description - Fix errors reported by PHPStan (nulls instead of strings & ints in a test file) - Run PHPStan in CI - ... and on PRs I'd also recommend protecting the default branch in repo settings and making the tests required before a PR can be merged. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-14 12:19:00 +03:00

closed this issue
added the
pull-request
label

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/google2fa#669

No description provided.

Rows
Columns