[PR #34] [MERGED] Use Base32 class for encode/decode #582

New issue

Closed

opened 2026-03-14 12:14:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 12:14:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/antonioribeiro/google2fa/pull/34
Author: @barryvdh
Created: 7/15/2016
Status: ✅ Merged
Merged: 7/17/2016
Merged by: @antonioribeiro

Base: master ← Head: patch-1

📝 Commits (1)

0d910e6 Use Base32 class for encode/decode

📊 Changes

1 file changed (+1 additions, -43 deletions)

View changed files

📝 src/Google2FA.php (+1 -43)

📄 Description

Was this intentionally not done? Seems cleaner to use both encode and decode from the same class, and easier to maintain :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/antonioribeiro/google2fa/pull/34 **Author:** [@barryvdh](https://github.com/barryvdh) **Created:** 7/15/2016 **Status:** ✅ Merged **Merged:** 7/17/2016 **Merged by:** [@antonioribeiro](https://github.com/antonioribeiro) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`0d910e6`](https://github.com/antonioribeiro/google2fa/commit/0d910e6ac013630d64a290ef248826b094c98e87) Use Base32 class for encode/decode ### 📊 Changes **1 file changed** (+1 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `src/Google2FA.php` (+1 -43) </details> ### 📄 Description Was this intentionally not done? Seems cleaner to use both encode and decode from the same class, and easier to maintain :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-14 12:14:23 +03:00

closed this issue
added the
pull-request
label

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/google2fa#582

No description provided.

Rows
Columns